Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-29 Thread Anton Khirnov
Quoting Brad Smith (2022-01-29 19:15:46) > On 1/29/2022 4:54 AM, Hendrik Leppkes wrote: > > > On Sat, Jan 29, 2022 at 5:45 AM Brad Smith > > wrote: > >> libatomic is dropped by --as-needed since it is not necessary. > >> > > Thats what this solution relies on, and thus there is no harm in adding

Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-29 Thread Brad Smith
On 1/29/2022 4:54 AM, Hendrik Leppkes wrote: On Sat, Jan 29, 2022 at 5:45 AM Brad Smith wrote: libatomic is dropped by --as-needed since it is not necessary. Thats what this solution relies on, and thus there is no harm in adding it. But it doesn't work, and the generated pkg-config files

Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-29 Thread Hendrik Leppkes
On Sat, Jan 29, 2022 at 5:45 AM Brad Smith wrote: > > libatomic is dropped by --as-needed since it is not necessary. > Thats what this solution relies on, and thus there is no harm in adding it. - Hendrik ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-28 Thread Brad Smith
On 1/26/2022 6:49 AM, Anton Khirnov wrote: Quoting Brad Smith (2022-01-23 20:40:30) Testing this commit out it does as I had suspected and even with --as-needed causes a false positive on OpenBSD / FreeBSD. Why? Looking at this again and thinking about what it does, the test as is is flawed

Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-26 Thread Anton Khirnov
Quoting Brad Smith (2022-01-23 20:40:30) > > Testing this commit out it does as I had suspected and even with --as-needed > causes a false positive on OpenBSD / FreeBSD. Why? -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-23 Thread Brad Smith
On 1/22/2022 4:00 AM, Hendrik Leppkes wrote: On Sat, Jan 22, 2022 at 7:43 AM Brad Smith wrote: On 1/19/2022 10:23 AM, James Almer wrote: On 1/19/2022 10:48 AM, Anton Khirnov wrote: C11 atomics in some configurations (e.g. 64bit operations on ppc64 with GCC) require linking to libatomic. F

Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-22 Thread Hendrik Leppkes
On Sat, Jan 22, 2022 at 7:43 AM Brad Smith wrote: > > On 1/19/2022 10:23 AM, James Almer wrote: > > > On 1/19/2022 10:48 AM, Anton Khirnov wrote: > >> C11 atomics in some configurations (e.g. 64bit operations on ppc64 with > >> GCC) require linking to libatomic. > >> > >> Fixes #9275 > >> --- > >>

Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-21 Thread Brad Smith
On 1/19/2022 10:23 AM, James Almer wrote: On 1/19/2022 10:48 AM, Anton Khirnov wrote: C11 atomics in some configurations (e.g. 64bit operations on ppc64 with GCC) require linking to libatomic. Fixes #9275 ---   configure | 25 -   1 file changed, 16 insertions(+), 9 dele

Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-19 Thread James Almer
On 1/19/2022 10:48 AM, Anton Khirnov wrote: C11 atomics in some configurations (e.g. 64bit operations on ppc64 with GCC) require linking to libatomic. Fixes #9275 --- configure | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/configure b/configure

[FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-19 Thread Anton Khirnov
C11 atomics in some configurations (e.g. 64bit operations on ppc64 with GCC) require linking to libatomic. Fixes #9275 --- configure | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/configure b/configure index 1413122d87..3059c154df 100755 --- a/confi

Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-19 Thread James Almer
On 1/19/2022 9:40 AM, Anton Khirnov wrote: Quoting James Almer (2022-01-19 13:34:20) On 1/19/2022 8:54 AM, Anton Khirnov wrote: C11 atomics in some configurations (e.g. 64bit operations on ppc64 with GCC) require linking to libatomic. --- Testing welcome, especially in configurations where *

Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-19 Thread Anton Khirnov
Quoting James Almer (2022-01-19 13:34:20) > > > On 1/19/2022 8:54 AM, Anton Khirnov wrote: > > C11 atomics in some configurations (e.g. 64bit operations on ppc64 with > > GCC) require linking to libatomic. > > --- > > Testing welcome, especially in configurations where > > * libatomic is not pres

Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-19 Thread Andreas Rheinhardt
James Almer: > > > On 1/19/2022 8:54 AM, Anton Khirnov wrote: >> C11 atomics in some configurations (e.g. 64bit operations on ppc64 with >> GCC) require linking to libatomic. >> --- >> Testing welcome, especially in configurations where >> * libatomic is not present >> * libatomic is actually nee

Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-19 Thread James Almer
On 1/19/2022 8:54 AM, Anton Khirnov wrote: C11 atomics in some configurations (e.g. 64bit operations on ppc64 with GCC) require linking to libatomic. --- Testing welcome, especially in configurations where * libatomic is not present * libatomic is actually needed --- configure | 9 -

[FFmpeg-devel] [PATCH] configure: link to libatomic when it's present

2022-01-19 Thread Anton Khirnov
C11 atomics in some configurations (e.g. 64bit operations on ppc64 with GCC) require linking to libatomic. --- Testing welcome, especially in configurations where * libatomic is not present * libatomic is actually needed --- configure | 9 - 1 file changed, 8 insertions(+), 1 deletion(-)