Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-30 Thread Andreas Cadhalpun
On 23.11.2016 00:23, Josh de Kock wrote: > On 22/11/2016 23:11, Andreas Cadhalpun wrote: >> On 22.11.2016 23:43, Josh de Kock wrote: >>> On 22/11/2016 22:33, Andreas Cadhalpun wrote: Because it avoids confusing users. And the checks for other system libraries should do this, too. >>>

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread wm4
On Tue, 22 Nov 2016 23:30:38 +0100 Carl Eugen Hoyos wrote: > 2016-11-22 23:15 GMT+01:00 Andreas Cadhalpun > : > > > disabled sdl && disable sdl2 > > +enabled sdl2 && sdl_requested=yes > > I consider this ugly and it makes sdl different to all other system > libraries: Why? Wait a moment, S

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Josh de Kock
On 22/11/2016 23:11, Andreas Cadhalpun wrote: On 22.11.2016 23:43, Josh de Kock wrote: On 22/11/2016 22:33, Andreas Cadhalpun wrote: Because it avoids confusing users. And the checks for other system libraries should do this, too. I see no real reason to add this, but neither a reason to blo

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Andreas Cadhalpun
On 22.11.2016 23:43, Josh de Kock wrote: > On 22/11/2016 22:33, Andreas Cadhalpun wrote: >> Because it avoids confusing users. And the checks for other system >> libraries should do this, too. >> > > I see no real reason to add this, but neither a reason to block it either. > I personally think th

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Josh de Kock
On 22/11/2016 22:33, Andreas Cadhalpun wrote: On 22.11.2016 23:30, Carl Eugen Hoyos wrote: 2016-11-22 23:15 GMT+01:00 Andreas Cadhalpun : disabled sdl && disable sdl2 +enabled sdl2 && sdl_requested=yes I consider this ugly That is very subjective. This goes both ways. and it makes sd

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Andreas Cadhalpun
On 22.11.2016 23:30, Carl Eugen Hoyos wrote: > 2016-11-22 23:15 GMT+01:00 Andreas Cadhalpun > : > >> disabled sdl && disable sdl2 >> +enabled sdl2 && sdl_requested=yes > > I consider this ugly That is very subjective. > and it makes sdl different to all other system libraries: Why? Because i

Re: [FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Carl Eugen Hoyos
2016-11-22 23:15 GMT+01:00 Andreas Cadhalpun : > disabled sdl && disable sdl2 > +enabled sdl2 && sdl_requested=yes I consider this ugly and it makes sdl different to all other system libraries: Why? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-deve

[FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

2016-11-22 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- configure | 4 1 file changed, 4 insertions(+) diff --git a/configure b/configure index 7d094df..0d85a54 100755 --- a/configure +++ b/configure @@ -5846,7 +5846,9 @@ if enabled gcrypt; then fi disabled sdl && disable sdl2 +enabled sdl2 && sdl_request