Re: [FFmpeg-devel] [PATCH] configure: enable warnings for shadowed variables

2024-09-09 Thread Vittorio Giovara
On Mon, Sep 9, 2024 at 1:23 PM Timo Rothenpieler wrote: > On 09/09/2024 12:02, Anton Khirnov wrote: > > Quoting Rémi Denis-Courmont (2024-09-09 09:32:07) > >> Hi, > >> > >> Le 8 septembre 2024 19:57:38 GMT+03:00, Timo Rothenpieler < > t...@rothenpieler.org> a écrit : > >>> > >>> Well, the reality

Re: [FFmpeg-devel] [PATCH] configure: enable warnings for shadowed variables

2024-09-09 Thread Timo Rothenpieler
On 09/09/2024 12:02, Anton Khirnov wrote: Quoting Rémi Denis-Courmont (2024-09-09 09:32:07) Hi, Le 8 septembre 2024 19:57:38 GMT+03:00, Timo Rothenpieler a écrit : Well, the reality is, that without printing all these warnings, nobody will ever fix them. Unless someone sits down and spends

Re: [FFmpeg-devel] [PATCH] configure: enable warnings for shadowed variables

2024-09-09 Thread Anton Khirnov
Quoting Rémi Denis-Courmont (2024-09-09 09:32:07) > Hi, > > Le 8 septembre 2024 19:57:38 GMT+03:00, Timo Rothenpieler > a écrit : > > > >Well, the reality is, that without printing all these warnings, nobody will > >ever fix them. > >Unless someone sits down and spends potentially multiple days

Re: [FFmpeg-devel] [PATCH] configure: enable warnings for shadowed variables

2024-09-09 Thread Rémi Denis-Courmont
Hi, Le 8 septembre 2024 19:57:38 GMT+03:00, Timo Rothenpieler a écrit : > >Well, the reality is, that without printing all these warnings, nobody will >ever fix them. >Unless someone sits down and spends potentially multiple days if not weeks of >work to fix all the current ones. > >If we pri

Re: [FFmpeg-devel] [PATCH] configure: enable warnings for shadowed variables

2024-09-08 Thread Timo Rothenpieler
On 08.09.2024 18:44, Zhao Zhili wrote: On Sep 8, 2024, at 20:39, Timo Rothenpieler wrote: On 08.09.2024 10:15, Andreas Rheinhardt wrote: Timo Rothenpieler: These can easily lead to incredibly confusing errors, and should practically never happen. I'd have loved to make this a -Werror even,

Re: [FFmpeg-devel] [PATCH] configure: enable warnings for shadowed variables

2024-09-08 Thread Zhao Zhili
> On Sep 8, 2024, at 20:39, Timo Rothenpieler wrote: > > On 08.09.2024 10:15, Andreas Rheinhardt wrote: >> Timo Rothenpieler: >>> These can easily lead to incredibly confusing errors, and should >>> practically never happen. >>> I'd have loved to make this a -Werror even, but sadly there is way

Re: [FFmpeg-devel] [PATCH] configure: enable warnings for shadowed variables

2024-09-08 Thread Timo Rothenpieler
On 08.09.2024 10:15, Andreas Rheinhardt wrote: Timo Rothenpieler: These can easily lead to incredibly confusing errors, and should practically never happen. I'd have loved to make this a -Werror even, but sadly there is way too many instances in the codebase right now that first needs to be weed

Re: [FFmpeg-devel] [PATCH] configure: enable warnings for shadowed variables

2024-09-08 Thread Andreas Rheinhardt
Timo Rothenpieler: > These can easily lead to incredibly confusing errors, and should > practically never happen. > I'd have loved to make this a -Werror even, but sadly there is way too > many instances in the codebase right now that first needs to be weeded > out. IMO these instances would need

Re: [FFmpeg-devel] [PATCH] configure: enable warnings for shadowed variables

2024-09-07 Thread Michael Niedermayer
On Sat, Sep 07, 2024 at 08:52:41PM +0200, Timo Rothenpieler wrote: > These can easily lead to incredibly confusing errors, and should > practically never happen. > I'd have loved to make this a -Werror even, but sadly there is way too > many instances in the codebase right now that first needs to b

[FFmpeg-devel] [PATCH] configure: enable warnings for shadowed variables

2024-09-07 Thread Timo Rothenpieler
These can easily lead to incredibly confusing errors, and should practically never happen. I'd have loved to make this a -Werror even, but sadly there is way too many instances in the codebase right now that first needs to be weeded out. --- configure | 1 + 1 file changed, 1 insertion(+) diff --