Re: [FFmpeg-devel] [PATCH] configure: check SDL2 function with a header

2018-01-06 Thread James Almer
On 1/7/2018 12:07 AM, KO Myung-Hun wrote: > Ping ? > > KO Myung-Hun wrote: >> Hi/2. >> >> Derek Buitenhuis wrote: >>> On 12/29/2017 6:36 AM, KO Myung-Hun wrote: Sorry about that. SDL2 uses SDLCALL to specify a calling convention. On OS/2, it's defined to `_System' which is simi

Re: [FFmpeg-devel] [PATCH] configure: check SDL2 function with a header

2018-01-06 Thread KO Myung-Hun
Ping ? KO Myung-Hun wrote: > Hi/2. > > Derek Buitenhuis wrote: >> On 12/29/2017 6:36 AM, KO Myung-Hun wrote: >>> Sorry about that. >>> >>> SDL2 uses SDLCALL to specify a calling convention. On OS/2, it's defined >>> to `_System' which is similar to `_cdecl' but does not prepend '_'. >>> >>> After

Re: [FFmpeg-devel] [PATCH] configure: check SDL2 function with a header

2018-01-01 Thread KO Myung-Hun
Hi/2. Derek Buitenhuis wrote: > On 12/29/2017 6:36 AM, KO Myung-Hun wrote: >> Sorry about that. >> >> SDL2 uses SDLCALL to specify a calling convention. On OS/2, it's defined >> to `_System' which is similar to `_cdecl' but does not prepend '_'. >> >> After all, without a header, a function is use

Re: [FFmpeg-devel] [PATCH] configure: check SDL2 function with a header

2017-12-29 Thread Derek Buitenhuis
On 12/29/2017 6:36 AM, KO Myung-Hun wrote: > Sorry about that. > > SDL2 uses SDLCALL to specify a calling convention. On OS/2, it's defined > to `_System' which is similar to `_cdecl' but does not prepend '_'. > > After all, without a header, a function is used without `_System'. And > linker wil

Re: [FFmpeg-devel] [PATCH] configure: check SDL2 function with a header

2017-12-28 Thread KO Myung-Hun
Hi/2. Derek Buitenhuis wrote: > On 12/28/2017 2:44 PM, KO Myung-Hun wrote: >> On OS/2, '_' is not prepended to a function name. >> --- >> configure | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > It's not immediately clear to be how checking a header instead relates > to functio

Re: [FFmpeg-devel] [PATCH] configure: check SDL2 function with a header

2017-12-28 Thread Derek Buitenhuis
On 12/28/2017 2:44 PM, KO Myung-Hun wrote: > On OS/2, '_' is not prepended to a function name. > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) It's not immediately clear to be how checking a header instead relates to function name mangling (or lack thereof)? - Derek

[FFmpeg-devel] [PATCH] configure: check SDL2 function with a header

2017-12-28 Thread KO Myung-Hun
On OS/2, '_' is not prepended to a function name. --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 70de780f82..f937ddf2be 100755 --- a/configure +++ b/configure @@ -6019,14 +6019,14 @@ fi if enabled sdl2; then SDL2_CONFIG="${cr