Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

2015-04-16 Thread Michael Niedermayer
On Wed, Apr 15, 2015 at 05:18:58PM +0200, Simon Thelen wrote: > Signed-off-by: Simon Thelen > --- > Implemented like the check for libx264 without the warn on fallback. Tested > on my system with pkg-config. > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) tested, works app

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

2015-04-16 Thread wm4
On Wed, 15 Apr 2015 20:24:23 -0300 James Almer wrote: > On 15/04/15 8:14 PM, Carl Eugen Hoyos wrote: > > Simon Thelen c-14.de> writes: > > > >> I don't particularly mind either way. I can resend > >> a version without fallback. > > > > Please keep the fallback, not all OS have pkg-config. > >

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

2015-04-15 Thread James Almer
On 15/04/15 8:14 PM, Carl Eugen Hoyos wrote: > Simon Thelen c-14.de> writes: > >> I don't particularly mind either way. I can resend >> a version without fallback. > > Please keep the fallback, not all OS have pkg-config. > > Carl Eugen There's no OS without pkg-config. Only broken or badly m

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

2015-04-15 Thread Carl Eugen Hoyos
Simon Thelen c-14.de> writes: > I don't particularly mind either way. I can resend > a version without fallback. Please keep the fallback, not all OS have pkg-config. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

2015-04-15 Thread Simon Thelen
On 15-04-15 at 14:03, James Almer wrote: > On 15/04/15 2:00 PM, wm4 wrote: > > On Wed, 15 Apr 2015 17:18:58 +0200 > > Simon Thelen wrote: > >> Signed-off-by: Simon Thelen [..] > > Isn't the fallback not needed anymore? > Yeah, the pkg-config check alone is enough. > There's currently no release o

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

2015-04-15 Thread James Almer
On 15/04/15 2:00 PM, wm4 wrote: > On Wed, 15 Apr 2015 17:18:58 +0200 > Simon Thelen wrote: > >> Signed-off-by: Simon Thelen >> --- >> Implemented like the check for libx264 without the warn on fallback. Tested >> on my system with pkg-config. >> configure | 3 ++- >> 1 file changed, 2 insertio

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

2015-04-15 Thread wm4
On Wed, 15 Apr 2015 17:18:58 +0200 Simon Thelen wrote: > Signed-off-by: Simon Thelen > --- > Implemented like the check for libx264 without the warn on fallback. Tested > on my system with pkg-config. > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/confi

[FFmpeg-devel] [PATCH] configure: add pkg-config support for libdcadec

2015-04-15 Thread Simon Thelen
Signed-off-by: Simon Thelen --- Implemented like the check for libx264 without the warn on fallback. Tested on my system with pkg-config. configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 389de92..1d98828 100755 --- a/configure +++ b/conf