Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-17 Thread Jörn Heusipp
On 10/16/2017 11:38 PM, Hendrik Leppkes wrote: On Mon, Oct 16, 2017 at 11:02 PM, James Almer wrote: The remaining issue after this patchset is applied is linking to the C++ standard library with some external deps. According to Jörn Heusipp, the libopenmpt maintainer, it's not something that

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-17 Thread Jörn Heusipp
On 10/17/2017 03:04 AM, Carl Eugen Hoyos wrote: 2017-10-16 23:02 GMT+02:00 James Almer : and by hardcoding a -lstdc++ ldflag in configure checks we're apparently breaking detection on systems where the compiler uses libc++, like it seems to be the case with Clang on MacOS. Did you test this?

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-17 Thread Jörn Heusipp
On 10/17/2017 12:13 AM, Jan Ekstrom wrote: On Tue, Oct 17, 2017 at 12:38 AM, Hendrik Leppkes wrote: Perhaps such libraries shouldn't hardcode -lstdc++ in there, but dynamically put whichever C++ library they built against in there instead? Its not like you can actually use a static library bui

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-16 Thread James Almer
On 10/16/2017 10:04 PM, Carl Eugen Hoyos wrote: > 2017-10-16 23:02 GMT+02:00 James Almer : >> and by hardcoding a -lstdc++ ldflag in configure checks we're >> apparently breaking detection on systems where the compiler >> uses libc++, like it seems to be the case with Clang on MacOS. > > Did you t

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-16 Thread Carl Eugen Hoyos
2017-10-16 23:02 GMT+02:00 James Almer : > and by hardcoding a -lstdc++ ldflag in configure checks we're > apparently breaking detection on systems where the compiler > uses libc++, like it seems to be the case with Clang on MacOS. Did you test this? I ask because I was never able to reproduce (it

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-16 Thread Jan Ekstrom
On Tue, Oct 17, 2017 at 12:38 AM, Hendrik Leppkes wrote: > Perhaps such libraries shouldn't hardcode -lstdc++ in there, but > dynamically put whichever C++ library they built against in there > instead? > Its not like you can actually use a static library build with another > C++ library, that *ma

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-16 Thread Hendrik Leppkes
On Mon, Oct 16, 2017 at 11:02 PM, James Almer wrote: > On 10/16/2017 2:36 PM, Jan Ekstrom wrote: >> On Mon, Oct 16, 2017 at 7:31 PM, James Almer wrote: >>> On 10/14/2017 12:59 PM, James Almer wrote: It's used by every library, and by making it global we simplify a lot of checks. >>

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-16 Thread James Almer
On 10/16/2017 2:36 PM, Jan Ekstrom wrote: > On Mon, Oct 16, 2017 at 7:31 PM, James Almer wrote: >> On 10/14/2017 12:59 PM, James Almer wrote: >>> It's used by every library, and by making it global we simplify a lot >>> of checks. >>> > > LGTM. > > I dislike the fact that we have to fix issues c

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-16 Thread Jan Ekstrom
On Mon, Oct 16, 2017 at 7:31 PM, James Almer wrote: > On 10/14/2017 12:59 PM, James Almer wrote: >> It's used by every library, and by making it global we simplify a lot >> of checks. >> LGTM. I dislike the fact that we have to fix issues caused by 3rd party libraries' pkg-config files but at th

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-16 Thread James Almer
On 10/14/2017 12:59 PM, James Almer wrote: > It's used by every library, and by making it global we simplify a lot > of checks. > > Signed-off-by: James Almer > --- > configure | 18 +++--- > 1 file changed, 7 insertions(+), 11 deletions(-) > > diff --git a/configure b/configure > i

[FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-14 Thread James Almer
It's used by every library, and by making it global we simplify a lot of checks. Signed-off-by: James Almer --- configure | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/configure b/configure index 22026ef832..a0bfb269e8 100755 --- a/configure +++ b/config