Re: [FFmpeg-devel] [PATCH] configure: add check_feature_test_macro for exp10, exp10f

2015-12-24 Thread Ganesh Ajjanagadde
On Thu, Dec 24, 2015 at 10:37 AM, Nicolas George wrote: > Le quartidi 4 nivôse, an CCXXIV, Ganesh Ajjanagadde a écrit : >> Before I rework, to make sure I understand, why don't other math >> functions merely test for a prototype as you suggest? > > Because it was never needed. There is rarely an i

Re: [FFmpeg-devel] [PATCH] configure: add check_feature_test_macro for exp10, exp10f

2015-12-24 Thread Nicolas George
Le quartidi 4 nivôse, an CCXXIV, Ganesh Ajjanagadde a écrit : > Before I rework, to make sure I understand, why don't other math > functions merely test for a prototype as you suggest? Because it was never needed. There is rarely an implementation without a prototype. Regards, -- Nicolas Geor

Re: [FFmpeg-devel] [PATCH] configure: add check_feature_test_macro for exp10, exp10f

2015-12-24 Thread Ganesh Ajjanagadde
On Thu, Dec 24, 2015 at 10:12 AM, Nicolas George wrote: > Le quartidi 4 nivôse, an CCXXIV, Ganesh Ajjanagadde a écrit : >> The prototype checking is already done above via check_mathfunc, which >> follows your idea. > > No, it is not done, and especially not the way I suggested. > >>

Re: [FFmpeg-devel] [PATCH] configure: add check_feature_test_macro for exp10, exp10f

2015-12-24 Thread Nicolas George
Le quartidi 4 nivôse, an CCXXIV, Ganesh Ajjanagadde a écrit : > The prototype checking is already done above via check_mathfunc, which > follows your idea. No, it is not done, and especially not the way I suggested. >The trouble is that check_ld succeeds with/without > GNU_SOU

Re: [FFmpeg-devel] [PATCH] configure: add check_feature_test_macro for exp10, exp10f

2015-12-24 Thread Ganesh Ajjanagadde
On Thu, Dec 24, 2015 at 9:55 AM, Nicolas George wrote: > Le quartidi 4 nivôse, an CCXXIV, Ganesh Ajjanagadde a écrit : >> exp10 and exp10f need _GNU_SOURCE. check_mathfunc only tests if the >> function is available, and not whether it is locked or unlocked via >> _GNU_SOURCE. >> >> This adds some

Re: [FFmpeg-devel] [PATCH] configure: add check_feature_test_macro for exp10, exp10f

2015-12-24 Thread Nicolas George
Le quartidi 4 nivôse, an CCXXIV, Ganesh Ajjanagadde a écrit : > exp10 and exp10f need _GNU_SOURCE. check_mathfunc only tests if the > function is available, and not whether it is locked or unlocked via > _GNU_SOURCE. > > This adds some support to configure to test for _GNU_SOURCE and > accordingly

[FFmpeg-devel] [PATCH] configure: add check_feature_test_macro for exp10, exp10f

2015-12-24 Thread Ganesh Ajjanagadde
exp10 and exp10f need _GNU_SOURCE. check_mathfunc only tests if the function is available, and not whether it is locked or unlocked via _GNU_SOURCE. This adds some support to configure to test for _GNU_SOURCE and accordingly report the existence of exp10, exp10f. Signed-off-by: Ganesh Ajjanagadde