Re: [FFmpeg-devel] [PATCH] cmdutils: use macros for device test

2014-12-14 Thread Lukasz Marek
On 13.12.2014 20:03, Michael Niedermayer wrote: On Sat, Dec 13, 2014 at 07:54:57PM +0100, Lukasz Marek wrote: Signed-off-by: Lukasz Marek --- cmdutils.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) LGTM pushed ___ ffmpeg-devel m

Re: [FFmpeg-devel] [PATCH] cmdutils: use macros for device test

2014-12-13 Thread Michael Niedermayer
On Sat, Dec 13, 2014 at 07:54:57PM +0100, Lukasz Marek wrote: > Signed-off-by: Lukasz Marek > --- > cmdutils.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use goto

[FFmpeg-devel] [PATCH] cmdutils: use macros for device test

2014-12-13 Thread Lukasz Marek
Signed-off-by: Lukasz Marek --- cmdutils.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/cmdutils.c b/cmdutils.c index b68dae9..4e0a406 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -1213,12 +1213,7 @@ static int is_device(const AVClass *avclass) { if (!avclass)