Re: [FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

Hi James, I agree with what you said, we should test 8 10 and 12 bit. But i noticed that hevc_idct and hevc_add_res also not test 12 bit. I think we should also add 12 bit for these checkasm codes. 2018-03-06 21:55 GMT+08:00 James Almer : > On 3/3/2018 12:15 AM, Yingming Fan wrote: > > --- > >

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

On 3/3/2018 12:15 AM, Yingming Fan wrote: > --- > tests/checkasm/Makefile | 2 +- > tests/checkasm/checkasm.c | 1 + > tests/checkasm/checkasm.h | 1 + > tests/checkasm/hevc_sao.c | 158 > ++ > tests/fate/checkasm.mak | 1 + > 5 files change

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

Hi there. We are working on add some neon optimization for hevc decoder. But before submit neon codes, i'd like to submit some checkasm codes. First one will be checkasm codes of SAO. I tested this path under MacOS 10.13.3 and Debian, all FATE case passed. So will anyone review this patch? Yi

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

Works for me on MacOs 10.12 (x86_64 and x86_32). Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

--- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_sao.c | 158 ++ tests/fate/checkasm.mak | 1 + 5 files changed, 162 insertions(+), 1 deletion(-) create mode 100644 tes

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

Thank you for your remind and i have already sent another patch fix the issue. Yingming Fan > On 3 Mar 2018, at 2:23 AM, Martin Vignali wrote: > > 2018-03-02 12:48 GMT+01:00 Yingming Fan >: > >> If you want to test checkasm of hevc_sao, please use `checkasm >> --

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

2018-03-02 12:48 GMT+01:00 Yingming Fan : > If you want to test checkasm of hevc_sao, please use `checkasm > --test=hevc_sao`, or `checkasm --test=hevc_sao --bench`. > > > > > On 2 Mar 2018, at 7:03 PM, Yingming Fan wrote: > > > > --- > > tests/checkasm/Makefile | 2 +- > > tests/checkasm/chec

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

If you want to test checkasm of hevc_sao, please use `checkasm --test=hevc_sao`, or `checkasm --test=hevc_sao --bench`. > On 2 Mar 2018, at 7:03 PM, Yingming Fan wrote: > > --- > tests/checkasm/Makefile | 2 +- > tests/checkasm/checkasm.c | 1 + > tests/checkasm/checkasm.h | 1 + > tests

[FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

--- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_sao.c | 158 ++ 4 files changed, 161 insertions(+), 1 deletion(-) create mode 100644 tests/checkasm/hevc_sao.c diff --git