[FFmpeg-devel] [PATCH] cbs: Add function to make content of a unit writable

2018-12-03 Thread Andreas Rheinhardt
This will enable us to change e.g. the parameter sets of H.2645 in ways that would change the parsing process of future units. An example of this is the h264_redundant_pps bsf. The actual implementation of the underlying codec-dependent make_writable functions is not contained in this commit. Sign

Re: [FFmpeg-devel] [PATCH] cbs: Add function to make content of a unit writable

2018-11-25 Thread Carl Eugen Hoyos
2018-11-25 22:44 GMT+01:00, Andreas Rheinhardt : > Carl Eugen Hoyos: >> 2018-11-25 22:05 GMT+01:00, Andreas Rheinhardt >> : >> >>> +.make_writable = NULL, >> >> Why do you think these are needed? >> > It's not needed. If left out, .make_writable will be implicitly initialized > to a NULL po

Re: [FFmpeg-devel] [PATCH] cbs: Add function to make content of a unit writable

2018-11-25 Thread Andreas Rheinhardt
Carl Eugen Hoyos: > 2018-11-25 22:05 GMT+01:00, Andreas Rheinhardt > : > >> +.make_writable = NULL, > > Why do you think these are needed? > > Carl Eugen It's not needed. If left out, .make_writable will be implicitly initialized to a NULL pointer because the various ff_cbs_type_xyz all

Re: [FFmpeg-devel] [PATCH] cbs: Add function to make content of a unit writable

2018-11-25 Thread Carl Eugen Hoyos
2018-11-25 22:05 GMT+01:00, Andreas Rheinhardt : > +.make_writable = NULL, Why do you think these are needed? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] cbs: Add function to make content of a unit writable

2018-11-25 Thread Andreas Rheinhardt
This will enable us to change e.g. the parameter sets of H.2645 in ways that would change the parsing process of future units. An example of this is the h264_redundant_pps bsf. The actual implementation of the underlying codec-dependent make_writable functions is not contained in this commit. Sign