Re: [FFmpeg-devel] [PATCH] build: fix msvc build

2016-01-23 Thread Hendrik Leppkes
On Sat, Jan 23, 2016 at 10:25 PM, Andreas Cadhalpun wrote: > On 23.01.2016 22:16, Charlie Arnold wrote: >> I did, works for both in and out of tree builds > > Applied and pushed. Thanks a lot! > pwd: unknown option -- W Try 'pwd --help' for more information. Please leave more than 5 minutes to r

Re: [FFmpeg-devel] [PATCH] build: fix msvc build

2016-01-23 Thread Andreas Cadhalpun
On 23.01.2016 22:33, Charlie Arnold wrote: > I can fix it to check $host_os = cygwin, and use cygpath in that case. I think that should work. > I don't have cygwin installed to test tho. Maybe someone who has could test the patch? Best regards, Andreas

Re: [FFmpeg-devel] [PATCH] build: fix msvc build

2016-01-23 Thread Charlie Arnold
I can fix it to check $host_os = cygwin, and use cygpath in that case. I don't have cygwin installed to test tho. On Sat, Jan 23, 2016 at 1:28 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 23.01.2016 22:25, James Darnley wrote: > > On 2016-01-23 22:11, charlie.arn...@gmai

Re: [FFmpeg-devel] [PATCH] build: fix msvc build

2016-01-23 Thread Andreas Cadhalpun
On 23.01.2016 22:25, James Darnley wrote: > On 2016-01-23 22:11, charlie.arn...@gmail.com wrote: >> +if enabled msvc; then >> +dst_path=$(pwd -W) >> +else >> +dst_path=$(pwd) >> +fi >> + > > If using MSVC through Cygwin is supported this would fail. Its pwd > command does not have the -W

Re: [FFmpeg-devel] [PATCH] build: fix msvc build

2016-01-23 Thread Andreas Cadhalpun
On 23.01.2016 22:16, Charlie Arnold wrote: > I did, works for both in and out of tree builds Applied and pushed. Thanks a lot! Best regards, Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] build: fix msvc build

2016-01-23 Thread James Darnley
On 2016-01-23 22:11, charlie.arn...@gmail.com wrote: > +if enabled msvc; then > +dst_path=$(pwd -W) > +else > +dst_path=$(pwd) > +fi > + If using MSVC through Cygwin is supported this would fail. Its pwd command does not have the -W option. Most people probably don't use both. signat

Re: [FFmpeg-devel] [PATCH] build: fix msvc build

2016-01-23 Thread Charlie Arnold
I did, works for both in and out of tree builds On Sat, Jan 23, 2016 at 1:15 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 23.01.2016 22:11, charlie.arn...@gmail.com wrote: > > From: Charlie Arnold > > > > Fix configure to set DST_PATH to the Windows style path when build

Re: [FFmpeg-devel] [PATCH] build: fix msvc build

2016-01-23 Thread Andreas Cadhalpun
On 23.01.2016 22:11, charlie.arn...@gmail.com wrote: > From: Charlie Arnold > > Fix configure to set DST_PATH to the Windows style path when building with > MSVC > --- > configure | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 8f46

[FFmpeg-devel] [PATCH] build: fix msvc build

2016-01-23 Thread charlie . arnold
From: Charlie Arnold Fix configure to set DST_PATH to the Windows style path when building with MSVC --- configure | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 8f4642b..f7d1000 100755 --- a/configure +++ b/configure @@ -6233,6 +6233,12 @@