On Sun, Nov 1, 2015 at 4:45 PM Michael Niedermayer
wrote:
> On Sun, Nov 01, 2015 at 10:40:03AM -0800, Timothy Gu wrote:
> > ---
> > libavfilter/vf_boxblur.c | 110
> +++
> > 1 file changed, 44 insertions(+), 66 deletions(-)
>
> LGTM
> thx
>
Pushed, th
On Sun, Nov 01, 2015 at 10:40:03AM -0800, Timothy Gu wrote:
> ---
> libavfilter/vf_boxblur.c | 110
> +++
> 1 file changed, 44 insertions(+), 66 deletions(-)
LGTM
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
T
On Sun, Nov 1, 2015 at 11:10 AM Ganesh Ajjanagadde wrote:
> Have not tested, but just a general comment. Personally, I follow the
> twice repition is ok, thrice means it is good to factor out. I would
> have been happier if the diff-stat was better than 44+/66- in terms of
> deletions.
The most
On Sun, Nov 1, 2015 at 1:40 PM, Timothy Gu wrote:
> ---
> libavfilter/vf_boxblur.c | 110
> +++
> 1 file changed, 44 insertions(+), 66 deletions(-)
>
> diff --git a/libavfilter/vf_boxblur.c b/libavfilter/vf_boxblur.c
> index ef01cf9..6934076 100644
> -
---
libavfilter/vf_boxblur.c | 110 +++
1 file changed, 44 insertions(+), 66 deletions(-)
diff --git a/libavfilter/vf_boxblur.c b/libavfilter/vf_boxblur.c
index ef01cf9..6934076 100644
--- a/libavfilter/vf_boxblur.c
+++ b/libavfilter/vf_boxblur.c
@@ -20
