Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-21 Thread Thomas Turner
Yes, you're correct. I'll look over the test and make sure there isn't anymore bugs before sending in the patch. Thanks On Dec 21, 2016 6:28 PM, "James Almer" wrote: On 12/21/2016 11:22 PM, Thomas Turner wrote: > yeah, currently taking a look. int tot_elements = !(planes = av_sample_fmt_is_pl

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-21 Thread James Almer
On 12/21/2016 11:22 PM, Thomas Turner wrote: > yeah, currently taking a look. int tot_elements = !(planes = av_sample_fmt_is_planar(afifo->sample_fmt)) ? samples : afifo->channels * samples; void **data_planes = allocate_memory(sizeof(void*) * planes); planes is zero when t

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-21 Thread Thomas Turner
yeah, currently taking a look. On 12/21/2016 06:08 PM, Michael Niedermayer wrote: On Wed, Dec 21, 2016 at 10:53:36PM -0300, James Almer wrote: On 12/21/2016 10:49 PM, Michael Niedermayer wrote: On Wed, Dec 21, 2016 at 09:45:39PM -0300, James Almer wrote: On 12/20/2016 11:36 PM, Michael Niede

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-21 Thread Michael Niedermayer
On Wed, Dec 21, 2016 at 10:53:36PM -0300, James Almer wrote: > On 12/21/2016 10:49 PM, Michael Niedermayer wrote: > > On Wed, Dec 21, 2016 at 09:45:39PM -0300, James Almer wrote: > >> On 12/20/2016 11:36 PM, Michael Niedermayer wrote: > >>> On Tue, Dec 20, 2016 at 04:53:51PM -0800, Thomas Turner wr

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-21 Thread James Almer
On 12/21/2016 10:49 PM, Michael Niedermayer wrote: > On Wed, Dec 21, 2016 at 09:45:39PM -0300, James Almer wrote: >> On 12/20/2016 11:36 PM, Michael Niedermayer wrote: >>> On Tue, Dec 20, 2016 at 04:53:51PM -0800, Thomas Turner wrote: Signed-off-by: Thomas Turner --- libavutil/Make

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-21 Thread Michael Niedermayer
On Wed, Dec 21, 2016 at 09:45:39PM -0300, James Almer wrote: > On 12/20/2016 11:36 PM, Michael Niedermayer wrote: > > On Tue, Dec 20, 2016 at 04:53:51PM -0800, Thomas Turner wrote: > >> Signed-off-by: Thomas Turner > >> --- > >> libavutil/Makefile | 1 + > >> libavutil/tests/audio_fif

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-21 Thread James Almer
On 12/20/2016 11:36 PM, Michael Niedermayer wrote: > On Tue, Dec 20, 2016 at 04:53:51PM -0800, Thomas Turner wrote: >> Signed-off-by: Thomas Turner >> --- >> libavutil/Makefile | 1 + >> libavutil/tests/audio_fifo.c | 196 + >> tests/fate/libavutil.

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-20 Thread Michael Niedermayer
On Tue, Dec 20, 2016 at 04:53:51PM -0800, Thomas Turner wrote: > Signed-off-by: Thomas Turner > --- > libavutil/Makefile | 1 + > libavutil/tests/audio_fifo.c | 196 + > tests/fate/libavutil.mak | 4 + > tests/ref/fate/audio_fifo| 228 > +

[FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-20 Thread Thomas Turner
Signed-off-by: Thomas Turner --- libavutil/Makefile | 1 + libavutil/tests/audio_fifo.c | 196 + tests/fate/libavutil.mak | 4 + tests/ref/fate/audio_fifo| 228 +++ 4 files changed, 429 insertions(+)

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-20 Thread Michael Niedermayer
On Mon, Dec 19, 2016 at 06:39:03PM -0800, Thomas Turner wrote: > Signed-off-by: Thomas Turner > --- > libavutil/Makefile | 1 + > libavutil/tests/audio_fifo.c | 195 > tests/fate/libavutil.mak | 4 + > tests/ref/fate/audio_fifo| 228 > ++

[FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-19 Thread Thomas Turner
Signed-off-by: Thomas Turner --- libavutil/Makefile | 1 + libavutil/tests/audio_fifo.c | 195 tests/fate/libavutil.mak | 4 + tests/ref/fate/audio_fifo| 228 +++ 4 files changed, 428 insertions(+)

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-17 Thread Michael Niedermayer
On Sat, Dec 17, 2016 at 03:16:30AM -0800, Thomas Turner wrote: > Signed-off-by: Thomas Turner > --- > libavutil/Makefile | 1 + > libavutil/tests/audio_fifo.c | 196 + > tests/fate/libavutil.mak | 4 + > tests/ref/fate/audio_fifo| 228 > +

[FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-17 Thread Thomas Turner
Signed-off-by: Thomas Turner --- libavutil/Makefile | 1 + libavutil/tests/audio_fifo.c | 196 + tests/fate/libavutil.mak | 4 + tests/ref/fate/audio_fifo| 228 +++ 4 files changed, 429 insertions(+)

Re: [FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-16 Thread Michael Niedermayer
On Thu, Dec 15, 2016 at 07:55:57PM -0800, Thomas Turner wrote: > Signed-off-by: Thomas Turner > --- > libavutil/Makefile | 1 + > libavutil/tests/audio_fifo.c | 210 +++ > tests/fate/libavutil.mak | 4 + > tests/ref/fate/audio_fifo| 228 >

[FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

2016-12-15 Thread Thomas Turner
Signed-off-by: Thomas Turner --- libavutil/Makefile | 1 + libavutil/tests/audio_fifo.c | 210 +++ tests/fate/libavutil.mak | 4 + tests/ref/fate/audio_fifo| 228 +++ 4 files changed, 443 insertions(