Re: [FFmpeg-devel] [PATCH] avutil/map: replace passing Compare functions by flags

2025-04-16 Thread Michael Niedermayer
On Wed, Apr 16, 2025 at 08:22:18PM +, softworkz . wrote: [...] > > That's a good change, because it was in fact confusing. > > Another confusing part of the API is the need for specifying the > lengths of key and value - and I finally figured out why it > didn't retrieve any elements: those

Re: [FFmpeg-devel] [PATCH] avutil/map: replace passing Compare functions by flags

2025-04-16 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Mittwoch, 16. April 2025 22:12 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: [FFmpeg-devel] [PATCH] avutil/map: replace passing Compare > func

[FFmpeg-devel] [PATCH] avutil/map: replace passing Compare functions by flags

2025-04-16 Thread Michael Niedermayer
This makes the API much more robust because if you receive a map from some other module you no longer need to know which compare function is correct for it Instead you just specify what you need, like AV_MAP_CMP_CASE_SENSITIVE or AV_MAP_CMP_CASE_INSENSITIVE or 0 if you dont care and the code will e