Re: [FFmpeg-devel] [PATCH] avutil/intmath: use bzhi gcc builtin in av_mod_uintp2()

On 26/06/15 8:14 PM, James Almer wrote: > Signed-off-by: James Almer > --- > Now making sure it's not used with ICC. Pushed the original. Oked by Cehoyos who confirmed ICC never reaches this code to begin with. ___ ffmpeg-devel mailing list ffmpeg-devel

[FFmpeg-devel] [PATCH] avutil/intmath: use bzhi gcc builtin in av_mod_uintp2()

Signed-off-by: James Almer --- Now making sure it's not used with ICC. libavutil/x86/intmath.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavutil/x86/intmath.h b/libavutil/x86/intmath.h index c42fa83..8127e10 100644 --- a/libavutil/x86/intmath.h +++ b/libavutil/x86/intmath.h @@

Re: [FFmpeg-devel] [PATCH] avutil/intmath: use bzhi gcc builtin in av_mod_uintp2()

On 26/06/15 4:56 PM, Carl Eugen Hoyos wrote: > On Friday 26 June 2015 09:52:31 pm James Almer wrote: > >> +#if AV_GCC_VERSION_AT_LEAST(5,1) >> +#define av_mod_uintp2 __builtin_ia32_bzhi_si > > Since there are compilers != gcc that define GCC > (for example icc), this needs a configure check imo.

Re: [FFmpeg-devel] [PATCH] avutil/intmath: use bzhi gcc builtin in av_mod_uintp2()

On Friday 26 June 2015 09:52:31 pm James Almer wrote: > +#if AV_GCC_VERSION_AT_LEAST(5,1) > +#define av_mod_uintp2 __builtin_ia32_bzhi_si Since there are compilers != gcc that define GCC (for example icc), this needs a configure check imo. What is the advantage over the inline version? Carl Eu

[FFmpeg-devel] [PATCH] avutil/intmath: use bzhi gcc builtin in av_mod_uintp2()

Signed-off-by: James Almer --- libavutil/x86/intmath.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavutil/x86/intmath.h b/libavutil/x86/intmath.h index c42fa83..85f15a4 100644 --- a/libavutil/x86/intmath.h +++ b/libavutil/x86/intmath.h @@ -39,6 +39,12 @@ #if defined(__BMI2__)