Re: [FFmpeg-devel] [PATCH] avutil/eval: Use better PRNG

2024-01-03 Thread Michael Niedermayer
On Thu, Jan 04, 2024 at 12:58:43AM +0100, Stefano Sabatini wrote: > On date Wednesday 2024-01-03 23:24:33 +0100, Michael Niedermayer wrote: [...] > > > +typedef struct KISS64State{ > > +uint64_t x,y,z,c; > > +}KISS64State; > > missing namespace here and in the functions below. > > For this

Re: [FFmpeg-devel] [PATCH] avutil/eval: Use better PRNG

2024-01-03 Thread James Almer
On 1/3/2024 8:58 PM, Stefano Sabatini wrote: missing namespace here and in the functions below. For this you could probably use AVKISS64PRNG (or AVKISS64), and use av_kiss64prng_ or av_kiss64_ as function prefix (I'd probably go with the shortest variant). It's not an installed header, so FF a

Re: [FFmpeg-devel] [PATCH] avutil/eval: Use better PRNG

2024-01-03 Thread Stefano Sabatini
On date Wednesday 2024-01-03 23:24:33 +0100, Michael Niedermayer wrote: > This is the 64bit version of George Marsaglias KISS PRNG > > Compared to the LCGs these produce much better quality numbers. > Compared to LFGs this needs less state. (our LFG has 224 byte > state for its 32bit version) this

[FFmpeg-devel] [PATCH] avutil/eval: Use better PRNG

2024-01-03 Thread Michael Niedermayer
This is the 64bit version of George Marsaglias KISS PRNG Compared to the LCGs these produce much better quality numbers. Compared to LFGs this needs less state. (our LFG has 224 byte state for its 32bit version) this has 32byte state for the 64bit version Also the initialization for our LFG is slo