Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-04-02 Thread Steven Liu
2017-04-02 17:41 GMT+08:00 Nicolas George : > Le decadi 10 germinal, an CCXXV, Steven Liu a écrit : > > refer to: http://creativeandcritical.net/str-replace-c > > add av_strreplace API for replace string operations. > > > > Signed-off-by: Steven Liu > > --- > > libavutil/avstring.c | 77

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-04-02 Thread Nicolas George
Le decadi 10 germinal, an CCXXV, Steven Liu a écrit : > refer to: http://creativeandcritical.net/str-replace-c > add av_strreplace API for replace string operations. > > Signed-off-by: Steven Liu > --- > libavutil/avstring.c | 77 > > libavut

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-04-01 Thread wm4
On Sat, 1 Apr 2017 22:34:26 +0200 Alexander Strasser wrote: > On 2017-04-01 13:12 +0200, wm4 wrote: > > On Sat, 1 Apr 2017 10:01:15 +0200 > > Nicolas George wrote: > [...] > > > Therefore, it was not acceptable as is and should not have been pushed. > > > > > > Pushing while leaving only half

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-04-01 Thread Alexander Strasser
On 2017-04-01 13:12 +0200, wm4 wrote: > On Sat, 1 Apr 2017 10:01:15 +0200 > Nicolas George wrote: [...] > > Therefore, it was not acceptable as is and should not have been pushed. > > > > Pushing while leaving only half a day to answer this was UNACCEPTABLE. > > Do not ever do it again please. >

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-04-01 Thread wm4
On Sat, 1 Apr 2017 10:01:15 +0200 Nicolas George wrote: > Le primidi 11 germinal, an CCXXV, Steven Liu a écrit : > > I think just similar, not duplicating, and the simple functionality use > > BPrint maybe too complex. > > Well, I will say it unambiguously: > > Parts of this patch DO duplicat

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-04-01 Thread Steven Liu
2017-04-01 16:01 GMT+08:00 Nicolas George : > Le primidi 11 germinal, an CCXXV, Steven Liu a écrit : > > I think just similar, not duplicating, and the simple functionality use > > BPrint maybe too complex. > > Well, I will say it unambiguously: > > Parts of this patch DO duplicate logic that we a

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-04-01 Thread Nicolas George
Le primidi 11 germinal, an CCXXV, Steven Liu a écrit : > I think just similar, not duplicating, and the simple functionality use > BPrint maybe too complex. Well, I will say it unambiguously: Parts of this patch DO duplicate logic that we already have, and your statement about BPrint being too co

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-03-31 Thread Steven Liu
2017-03-31 20:11 GMT+08:00 Steven Liu : > > > 2017-03-31 17:51 GMT+08:00 Nicolas George : > >> Le decadi 10 germinal, an CCXXV, Steven Liu a écrit : >> > refer to: http://creativeandcritical.net/str-replace-c >> > add av_strreplace API for replace string operations. >> > >> > Signed-off-by: Steven

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-03-31 Thread Steven Liu
2017-03-31 17:51 GMT+08:00 Nicolas George : > Le decadi 10 germinal, an CCXXV, Steven Liu a écrit : > > refer to: http://creativeandcritical.net/str-replace-c > > add av_strreplace API for replace string operations. > > > > Signed-off-by: Steven Liu > > --- > > libavutil/avstring.c | 77

Re: [FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-03-31 Thread Nicolas George
Le decadi 10 germinal, an CCXXV, Steven Liu a écrit : > refer to: http://creativeandcritical.net/str-replace-c > add av_strreplace API for replace string operations. > > Signed-off-by: Steven Liu > --- > libavutil/avstring.c | 77 > > libavut

[FFmpeg-devel] [PATCH] avutil/avstring: add av_strreplace API into avstring

2017-03-30 Thread Steven Liu
refer to: http://creativeandcritical.net/str-replace-c add av_strreplace API for replace string operations. Signed-off-by: Steven Liu --- libavutil/avstring.c | 77 libavutil/avstring.h | 5 2 files changed, 82 insertions(+) diff --git