Re: [FFmpeg-devel] [PATCH] avutil/attributes: add av_warn_unused_result

2015-10-05 Thread Michael Niedermayer
On Mon, Oct 05, 2015 at 01:45:12AM -0400, Ganesh Ajjanagadde wrote: > GCC 3.4 introduced an attribute warn_unused_result to warn when a programmer > discards the return value. Applying this judiciously across the codebase can > help > in fixing a lot of problems. At a high level, functions which r

[FFmpeg-devel] [PATCH] avutil/attributes: add av_warn_unused_result

2015-10-04 Thread Ganesh Ajjanagadde
GCC 3.4 introduced an attribute warn_unused_result to warn when a programmer discards the return value. Applying this judiciously across the codebase can help in fixing a lot of problems. At a high level, functions which return error codes should always be checked. More concretely, consider the fu