I can confirm the current source tree has resolved our issue.
On Fri, May 19, 2017 at 12:16 PM Michael Niedermayer
wrote:
> On Fri, May 19, 2017 at 08:28:23PM +0200, Michael Niedermayer wrote:
> > hi
> >
> > On Thu, May 18, 2017 at 10:58:39PM +, Rob Meyers wrote:
> > > avio_read does multipl
On Fri, May 19, 2017 at 08:28:23PM +0200, Michael Niedermayer wrote:
> hi
>
> On Thu, May 18, 2017 at 10:58:39PM +, Rob Meyers wrote:
> > avio_read does multiple calls to fill_buffer(). Adjusting things in
> > fill_buffer was frowned upon; how would you suggest I approach this?
>
> Its not fr
hi
On Thu, May 18, 2017 at 10:58:39PM +, Rob Meyers wrote:
> avio_read does multiple calls to fill_buffer(). Adjusting things in
> fill_buffer was frowned upon; how would you suggest I approach this?
Its not frowned upon to fix a bug in fill_buffer(), its frowned
upon to make a random change
avio_read does multiple calls to fill_buffer(). Adjusting things in
fill_buffer was frowned upon; how would you suggest I approach this? The
id3v2 seek doesn't come into play; the return from avio_read is the "full"
read.
The call I added in avio_read is only done when there was accumulated data,
On Thu, May 18, 2017 at 01:12:49PM -0700, Rob Meyers wrote:
> avio_read may make multiple calls to fill_buffer to accumulate bytes
> to fulfill a request. fill_buffer will overwrite previously read data
> if it is not prepped. Added a call to 'ffio_ensure_seekback' to adjust
> the s->buffer to fill
avio_read may make multiple calls to fill_buffer to accumulate bytes
to fulfill a request. fill_buffer will overwrite previously read data
if it is not prepped. Added a call to 'ffio_ensure_seekback' to adjust
the s->buffer to fill_buffer's liking. This isn't necessary for the
very first call to fi
