Re: [FFmpeg-devel] [PATCH] avidec: fix leaking extradata

2016-11-29 Thread Andreas Cadhalpun
On 30.11.2016 01:29, Michael Niedermayer wrote: > On Wed, Nov 30, 2016 at 12:21:41AM +0100, Andreas Cadhalpun wrote: >> avidec.c |8 >> 1 file changed, 8 insertions(+) >> 88b8c27a72e7ec4519e92eee5a3a2764a657a823 >> 0001-avidec-fix-leaking-extradata.patch >> From e6a4fc92a99e2e378973

Re: [FFmpeg-devel] [PATCH] avidec: fix leaking extradata

2016-11-29 Thread Michael Niedermayer
On Wed, Nov 30, 2016 at 12:21:41AM +0100, Andreas Cadhalpun wrote: > On 29.11.2016 02:49, Michael Niedermayer wrote: > > On Tue, Nov 29, 2016 at 12:33:17AM +0100, Andreas Cadhalpun wrote: > >> Signed-off-by: Andreas Cadhalpun > >> --- > >> libavformat/avidec.c | 2 ++ > >> 1 file changed, 2 inser

Re: [FFmpeg-devel] [PATCH] avidec: fix leaking extradata

2016-11-29 Thread Andreas Cadhalpun
On 29.11.2016 02:49, Michael Niedermayer wrote: > On Tue, Nov 29, 2016 at 12:33:17AM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/avidec.c | 2 ++ >> 1 file changed, 2 insertions(+) > > If previous extradata is freed it should probably print a warning

Re: [FFmpeg-devel] [PATCH] avidec: fix leaking extradata

2016-11-28 Thread Michael Niedermayer
On Tue, Nov 29, 2016 at 12:33:17AM +0100, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/avidec.c | 2 ++ > 1 file changed, 2 insertions(+) If previous extradata is freed it should probably print a warning or error out [...] -- Michael GnuPG fingerprint: 9F

[FFmpeg-devel] [PATCH] avidec: fix leaking extradata

2016-11-28 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavformat/avidec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index e5a292e..97dbeae 100644 --- a/libavformat/avidec.c +++ b/libavformat/avidec.c @@ -770,6 +770,7 @@ FF_ENABLE_DEPRECATION_WARNINGS