Re: [FFmpeg-devel] [PATCH] avformat: remove unused MP4A_LATM flag

2018-06-12 Thread Gyan Doshi
On 12-06-2018 11:00 PM, James Almer wrote: Is that correct? I assume the other changes can be committed as-is. Yes, that should do it. Revised and pushed. Thanks, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mail

Re: [FFmpeg-devel] [PATCH] avformat: remove unused MP4A_LATM flag

2018-06-12 Thread James Almer
On 6/12/2018 5:33 AM, Gyan Doshi wrote: > > > On 12-06-2018 01:39 PM, Hendrik Leppkes wrote: > >> This flag is part of the public API, and eventhough it is entirely >> unused, you cannot remove public API without a proper deprecation >> period. > > Ok, so looking at older flags, I need to > >

Re: [FFmpeg-devel] [PATCH] avformat: remove unused MP4A_LATM flag

2018-06-12 Thread Gyan Doshi
On 12-06-2018 01:39 PM, Hendrik Leppkes wrote: This flag is part of the public API, and eventhough it is entirely unused, you cannot remove public API without a proper deprecation period. Ok, so looking at older flags, I need to add a define to version.h, something like #ifndef FF_API_LAVF

Re: [FFmpeg-devel] [PATCH] avformat: remove unused MP4A_LATM flag

2018-06-12 Thread Hendrik Leppkes
On Tue, Jun 12, 2018 at 7:00 AM Gyan Doshi wrote: > > > Will push tomorrow. This flag is part of the public API, and eventhough it is entirely unused, you cannot remove public API without a proper deprecation period. - Hendrik ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] avformat: remove unused MP4A_LATM flag

2018-06-11 Thread Gyan Doshi
Will push tomorrow. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avformat: remove unused MP4A_LATM flag

2018-06-10 Thread Gyan Doshi
From 5d3ab077f46fe14eaf5aa1246f975d847cf85e29 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sun, 10 Jun 2018 20:18:10 +0530 Subject: [PATCH] avformat: remove unused MP4A_LATM flag A generic lavf option for AAC LATM packetization for the RTP muxer was added in ef409645f0 and then made inert 20 d