Re: [FFmpeg-devel] [PATCH] avformat: move priv_pts from AVStream to an internal struct

2017-11-07 Thread James Almer
On 11/6/2017 8:43 PM, Michael Niedermayer wrote: > On Sun, Nov 05, 2017 at 03:06:56PM -0300, James Almer wrote: >> It has no reason to be in a public header, even if defined as private. >> >> Signed-off-by: James Almer >> --- >> To be honest, none of the fields below the "not part of the API" noti

Re: [FFmpeg-devel] [PATCH] avformat: move priv_pts from AVStream to an internal struct

2017-11-06 Thread Michael Niedermayer
On Sun, Nov 05, 2017 at 03:06:56PM -0300, James Almer wrote: > It has no reason to be in a public header, even if defined as private. > > Signed-off-by: James Almer > --- > To be honest, none of the fields below the "not part of the API" notice > have any reason to be in the public struct, but th

[FFmpeg-devel] [PATCH] avformat: move priv_pts from AVStream to an internal struct

2017-11-05 Thread James Almer
It has no reason to be in a public header, even if defined as private. Signed-off-by: James Almer --- To be honest, none of the fields below the "not part of the API" notice have any reason to be in the public struct, but this one is particularly pointless and ugly to have there as FFFrac is defi