Re: [FFmpeg-devel] [PATCH] avformat: close parser if codec changed

2016-11-03 Thread Andreas Cadhalpun
On 03.11.2016 11:07, Michael Niedermayer wrote: > On Thu, Nov 03, 2016 at 01:04:21AM +0100, Andreas Cadhalpun wrote: >> Yes, but it's not clear that the parser internal state is still correct >> after a change of the codec id. > > what exact case are we talking about ? > > A. The parser changeing

Re: [FFmpeg-devel] [PATCH] avformat: close parser if codec changed

2016-11-03 Thread Michael Niedermayer
On Thu, Nov 03, 2016 at 01:04:21AM +0100, Andreas Cadhalpun wrote: > On 03.11.2016 00:42, Michael Niedermayer wrote: > > On Wed, Nov 02, 2016 at 10:30:30PM +0100, Andreas Cadhalpun wrote: > >> On 02.11.2016 13:07, Michael Niedermayer wrote: > >>> On Sat, Oct 22, 2016 at 01:16:00AM +0200, Andreas Ca

Re: [FFmpeg-devel] [PATCH] avformat: close parser if codec changed

2016-11-02 Thread Andreas Cadhalpun
On 03.11.2016 00:42, Michael Niedermayer wrote: > On Wed, Nov 02, 2016 at 10:30:30PM +0100, Andreas Cadhalpun wrote: >> On 02.11.2016 13:07, Michael Niedermayer wrote: >>> On Sat, Oct 22, 2016 at 01:16:00AM +0200, Andreas Cadhalpun wrote: utils.c | 12 1 file changed, 12 i

Re: [FFmpeg-devel] [PATCH] avformat: close parser if codec changed

2016-11-02 Thread Michael Niedermayer
On Wed, Nov 02, 2016 at 10:30:30PM +0100, Andreas Cadhalpun wrote: > On 02.11.2016 13:07, Michael Niedermayer wrote: > > On Sat, Oct 22, 2016 at 01:16:00AM +0200, Andreas Cadhalpun wrote: > >> utils.c | 12 > >> 1 file changed, 12 insertions(+) > >> ffefc22756b774cb7652587207ae66cfb

Re: [FFmpeg-devel] [PATCH] avformat: close parser if codec changed

2016-11-02 Thread Andreas Cadhalpun
On 02.11.2016 13:07, Michael Niedermayer wrote: > On Sat, Oct 22, 2016 at 01:16:00AM +0200, Andreas Cadhalpun wrote: >> utils.c | 12 >> 1 file changed, 12 insertions(+) >> ffefc22756b774cb7652587207ae66cfbf681be3 >> 0001-avformat-close-parser-if-codec-changed.patch >> From 9de87a

Re: [FFmpeg-devel] [PATCH] avformat: close parser if codec changed

2016-11-02 Thread Michael Niedermayer
On Sat, Oct 22, 2016 at 01:16:00AM +0200, Andreas Cadhalpun wrote: > On 22.10.2016 00:18, Michael Niedermayer wrote: > > On Mon, Oct 17, 2016 at 08:49:23PM +0200, Andreas Cadhalpun wrote: > >> The parser depends on the codec and thus must not be used with a different > >> one. > >> If it is, the '

Re: [FFmpeg-devel] [PATCH] avformat: close parser if codec changed

2016-10-26 Thread Andreas Cadhalpun
On 22.10.2016 01:16, Andreas Cadhalpun wrote: > From 9de87a4fb2c6c6311a11a2da5de8554a71adfa66 Mon Sep 17 00:00:00 2001 > From: Andreas Cadhalpun > Date: Mon, 17 Oct 2016 20:26:51 +0200 > Subject: [PATCH] avformat: close parser if codec changed > > The parser depends on the codec and thus must not

Re: [FFmpeg-devel] [PATCH] avformat: close parser if codec changed

2016-10-21 Thread Andreas Cadhalpun
On 22.10.2016 00:18, Michael Niedermayer wrote: > On Mon, Oct 17, 2016 at 08:49:23PM +0200, Andreas Cadhalpun wrote: >> The parser depends on the codec and thus must not be used with a different >> one. >> If it is, the 'avctx->codec_id == s->parser->codec_ids[0] ...' assert in >> av_parser_parse2

Re: [FFmpeg-devel] [PATCH] avformat: close parser if codec changed

2016-10-21 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 08:49:23PM +0200, Andreas Cadhalpun wrote: > The parser depends on the codec and thus must not be used with a different > one. > If it is, the 'avctx->codec_id == s->parser->codec_ids[0] ...' assert in > av_parser_parse2 gets triggered. > > Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH] avformat: close parser if codec changed

2016-10-21 Thread Andreas Cadhalpun
On 17.10.2016 20:49, Andreas Cadhalpun wrote: > The parser depends on the codec and thus must not be used with a different > one. > If it is, the 'avctx->codec_id == s->parser->codec_ids[0] ...' assert in > av_parser_parse2 gets triggered. > > Signed-off-by: Andreas Cadhalpun > --- > libavforma

[FFmpeg-devel] [PATCH] avformat: close parser if codec changed

2016-10-17 Thread Andreas Cadhalpun
The parser depends on the codec and thus must not be used with a different one. If it is, the 'avctx->codec_id == s->parser->codec_ids[0] ...' assert in av_parser_parse2 gets triggered. Signed-off-by: Andreas Cadhalpun --- libavformat/utils.c | 12 1 file changed, 12 insertions(+)