Re: [FFmpeg-devel] [PATCH] avformat: add DAT (Digital Audio Tape) demuxer

2025-02-08 Thread Jerome Martinez
Le 01/02/2025 à 03:13, Michael Niedermayer a écrit : [...] yes, this is the 2nd such dumb mistake i make in the last few days the whole (still ongoing) "mobbing" compaign against me seems to affect the quality of my reviews and work Sorry to read that, I hope that this will stop soon. [...] d

Re: [FFmpeg-devel] [PATCH] avformat: add DAT (Digital Audio Tape) demuxer

2025-01-31 Thread Michael Niedermayer
Hi Jerome On Wed, Jan 29, 2025 at 06:02:57PM +0100, Jerome Martinez wrote: > Le 25/01/2025 à 01:46, Michael Niedermayer a écrit : > > [...] > > this passes tests. > > > > but if you want, you could instead of testing "extra metadata (not needed > > for decoding)" > > test more than 1 packet > >

Re: [FFmpeg-devel] [PATCH] avformat: add DAT (Digital Audio Tape) demuxer

2025-01-29 Thread Jerome Martinez
Le 25/01/2025 à 01:46, Michael Niedermayer a écrit : [...] this passes tests. but if you want, you could instead of testing "extra metadata (not needed for decoding)" test more than 1 packet having a best case score of 1 seems to be something that will likely fail sooner or later by not detect

Re: [FFmpeg-devel] [PATCH] avformat: add DAT (Digital Audio Tape) demuxer

2025-01-24 Thread Michael Niedermayer
On Wed, Jan 22, 2025 at 12:26:17PM +0100, Jerome Martinez wrote: > Le 17/01/2025 à 21:43, Michael Niedermayer a écrit : > > On Fri, Jan 17, 2025 at 12:38:02PM +0100, Jerome Martinez wrote: > > > [...] > > > Subject: [PATCH] avformat: add DAT demuxer > > breaks fate-cdxl-pal8-small > > > > I guess

Re: [FFmpeg-devel] [PATCH] avformat: add DAT (Digital Audio Tape) demuxer

2025-01-22 Thread Jerome Martinez
Le 17/01/2025 à 21:43, Michael Niedermayer a écrit : On Fri, Jan 17, 2025 at 12:38:02PM +0100, Jerome Martinez wrote: [...] Subject: [PATCH] avformat: add DAT demuxer breaks fate-cdxl-pal8-small I guess the probe function is not working as expected cdxl parser provides a read_probe value of

Re: [FFmpeg-devel] [PATCH] avformat: add DAT (Digital Audio Tape) demuxer

2025-01-17 Thread Michael Niedermayer
Hi On Fri, Jan 17, 2025 at 12:38:02PM +0100, Jerome Martinez wrote: > Sample files are available at https://archive.org/download/datstrue-read/ > > Makefile |1 > allformats.c |1 > dat.c| 159 > +++ > 3 files chang

[FFmpeg-devel] [PATCH] avformat: add DAT (Digital Audio Tape) demuxer

2025-01-17 Thread Jerome Martinez
Sample files are available at https://archive.org/download/datstrue-read/ From 50c78a0ae2049e2dbd65e2c3d28f3d8abea1adfa Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Thu, 12 Sep 2024 20:34:22 +0200 Subject: [PATCH] avformat: add DAT demuxer --- libavformat/Makefile | 1 + libavformat