Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-16 Thread Rodger Combs
> On Dec 14, 2014, at 10:06, Nicolas George wrote: > > Le tridi 23 frimaire, an CCXXIII, Rodger Combs a écrit : >> I couldn't see a sensible way to do this in lavc, since the detector >> libraries generally require more than one packet to work effectively. >> Looking at that doxy again, I can se

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-14 Thread Nicolas George
Le tridi 23 frimaire, an CCXXIII, Carl Eugen Hoyos a écrit : > Imo, if your distribution contains the libraries > but does not install them by default, it is a > good indication that we should not auto-detect > them. This is a matter of taste. FFmpeg has that policy, but MPlayer, on the other h

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-14 Thread Nicolas George
Le tridi 23 frimaire, an CCXXIII, Rodger Combs a écrit : > I couldn't see a sensible way to do this in lavc, since the detector > libraries generally require more than one packet to work effectively. > Looking at that doxy again, I can see how the detection could be done in > lavf and the conversio

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-13 Thread wm4
On Sat, 13 Dec 2014 16:17:48 +0100 Nicolas George wrote: > Le tridi 23 frimaire, an CCXXIII, wm4 a écrit : > > What about it is bogus? > > Read the documentation. Broken library design. > > In fact, the UTF-16 change made > > UTF-16 just work with any API user.

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-13 Thread Nicolas George
Le tridi 23 frimaire, an CCXXIII, wm4 a écrit : > What about it is bogus? Read the documentation. >In fact, the UTF-16 change made > UTF-16 just work with any API user. And inconsistent values in the context. > Recoding in the demuxer is unacceptable, because

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-13 Thread wm4
On Sat, 13 Dec 2014 12:34:28 +0100 Nicolas George wrote: > First, your patch seems to happen after the text demuxers have parsed the > text files. Therefore, this can not work for non-ASCII-compatible encodings, > such as UTF-16. You might say that UTF-16 already works, but its > implementation i

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-13 Thread wm4
On Fri, 12 Dec 2014 00:05:27 -0600 Rodger Combs wrote: > This also moves general charenc conversion from avcodec to avformat; > the version in avcodec is left, but renamed; I'm not sure if that's > the optimal solution. > > The documentation could probably use some improvements, and a few more >

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-13 Thread Rodger Combs
> On Dec 13, 2014, at 05:34, Nicolas George wrote: > > So, now that I have a decent connection and time, here are some comments: > > First, your patch seems to happen after the text demuxers have parsed the > text files. Therefore, this can not work for non-ASCII-compatible encodings, > such as

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-13 Thread Carl Eugen Hoyos
Rodger Combs gmail.com> writes: > + --disable-libguess disable libguess [autodetect] > + --disable-uchardet disable universalchardet [autodetect] I cannot comment on your actual patch, but both libraries should not be auto-detected imo. Imo, if your distribution contains the libr

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-13 Thread Nicolas George
Le duodi 22 frimaire, an CCXXIII, Rodger Combs a écrit : > This also moves general charenc conversion from avcodec to avformat; > the version in avcodec is left, but renamed; I'm not sure if that's > the optimal solution. > > The documentation could probably use some improvements, and a few more >

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-12 Thread Lukasz Marek
On 12 December 2014 at 07:05, Rodger Combs wrote: > > diff --git a/configure b/configure > index e2e3619..a5a9f9b 100755 > --- a/configure > +++ b/configure > @@ -199,6 +199,9 @@ External library support: >--enable-gnutls enable gnutls, needed for https support >

Re: [FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-12 Thread Nicolas George
Le duodi 22 frimaire, an CCXXIII, Rodger Combs a écrit : > This also moves general charenc conversion from avcodec to avformat; > the version in avcodec is left, but renamed; I'm not sure if that's > the optimal solution. > > The documentation could probably use some improvements, and a few more >

[FFmpeg-devel] [PATCH] avformat: Implement subtitle charenc guessing

2014-12-11 Thread Rodger Combs
This also moves general charenc conversion from avcodec to avformat; the version in avcodec is left, but renamed; I'm not sure if that's the optimal solution. The documentation could probably use some improvements, and a few more options could be added to ENCA. This very simply prefers libguess o