Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-09-07 Thread Michael Niedermayer
On Fri, Sep 06, 2019 at 05:00:14PM -0700, Niki Bowe wrote: > As it turns out the last patch still lets a lot of jpegs get misidentified. > > This new version avoids the problem by checking for jpeg magic at the start. > > I also added a FATE test, and attached the jpeg for the test. > > > > On

Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-09-06 Thread Niki Bowe
As it turns out the last patch still lets a lot of jpegs get misidentified. This new version avoids the problem by checking for jpeg magic at the start. I also added a FATE test, and attached the jpeg for the test. On Tue, Aug 27, 2019 at 6:30 PM Niki Bowe wrote: > > > On Sun, Aug 25, 2019 a

Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-08-27 Thread Niki Bowe
On Sun, Aug 25, 2019 at 11:39 AM Michael Niedermayer wrote: > On Fri, Aug 23, 2019 at 04:03:10PM -0700, Niki Bowe wrote: > > On Thu, Aug 22, 2019 at 2:30 AM Paul B Mahol wrote: > > > > > On Thu, Aug 22, 2019 at 11:19 AM Carl Eugen Hoyos > > > wrote: > > > > > > > Am Mi., 21. Aug. 2019 um 23:05

Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-08-25 Thread Michael Niedermayer
On Fri, Aug 23, 2019 at 04:03:10PM -0700, Niki Bowe wrote: > On Thu, Aug 22, 2019 at 2:30 AM Paul B Mahol wrote: > > > On Thu, Aug 22, 2019 at 11:19 AM Carl Eugen Hoyos > > wrote: > > > > > Am Mi., 21. Aug. 2019 um 23:05 Uhr schrieb Niki Bowe > > > : > > > > > > > > On Mon, Aug 19, 2019 at 7:22

Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-08-23 Thread Niki Bowe
On Thu, Aug 22, 2019 at 2:30 AM Paul B Mahol wrote: > On Thu, Aug 22, 2019 at 11:19 AM Carl Eugen Hoyos > wrote: > > > Am Mi., 21. Aug. 2019 um 23:05 Uhr schrieb Niki Bowe > > : > > > > > > On Mon, Aug 19, 2019 at 7:22 PM Carl Eugen Hoyos > > wrote: > > > > > > > > > > > This score would mean t

Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-08-22 Thread Paul B Mahol
On Thu, Aug 22, 2019 at 11:19 AM Carl Eugen Hoyos wrote: > Am Mi., 21. Aug. 2019 um 23:05 Uhr schrieb Niki Bowe > : > > > > On Mon, Aug 19, 2019 at 7:22 PM Carl Eugen Hoyos > wrote: > > > > > > > > This score would mean that mjpeg can never be detected. > > > I suspect you have to reduce one of

Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-08-22 Thread Carl Eugen Hoyos
Am Mi., 21. Aug. 2019 um 23:05 Uhr schrieb Niki Bowe : > > On Mon, Aug 19, 2019 at 7:22 PM Carl Eugen Hoyos wrote: > > > > > This score would mean that mjpeg can never be detected. > > I suspect you have to reduce one of the demuxers to "- 1". > > > > > Thanks Carl. > Attached patch to reduce mpeg

Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-08-22 Thread Michael Niedermayer
On Wed, Aug 21, 2019 at 01:58:52PM -0700, Niki Bowe wrote: > On Mon, Aug 19, 2019 at 7:22 PM Carl Eugen Hoyos wrote: > > > > > This score would mean that mjpeg can never be detected. > > I suspect you have to reduce one of the demuxers to "- 1". > > > > > Thanks Carl. > Attached patch to reduce m

Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-08-21 Thread Niki Bowe
On Mon, Aug 19, 2019 at 7:22 PM Carl Eugen Hoyos wrote: > > This score would mean that mjpeg can never be detected. > I suspect you have to reduce one of the demuxers to "- 1". > > Thanks Carl. Attached patch to reduce mpeg probe by -1, which also fixes the issue. Alternatively I could bump both

Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-08-19 Thread Carl Eugen Hoyos
Am Di., 20. Aug. 2019 um 03:37 Uhr schrieb Nikolas Bowe : > > Fixes "Invalid data found when processing input" on some JPEGs. > > Some large extensionless JPEGs can get probe score collisions. > eg > $ ffprobe -loglevel trace /tmp/foo > [NULL @ 0x55c130ab04c0] Opening '/tmp/foo' for reading > [fil

[FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-08-19 Thread Nikolas Bowe
Fixes "Invalid data found when processing input" on some JPEGs. Some large extensionless JPEGs can get probe score collisions. eg $ ffprobe -loglevel trace /tmp/foo [NULL @ 0x55c130ab04c0] Opening '/tmp/foo' for reading [file @ 0x55c130ab0f40] Setting default whitelist 'file,crypto' Probing jpeg_