Re: [FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

2020-06-24 Thread Andriy Gelman
On Sat, 20. Jun 22:46, Florian Levis wrote: > > Le sam. 20 juin 2020 à 20:56, Andriy Gelman a > écrit : > > > On Sat, 20. Jun 19:16, Levis Florian wrote: > > > Signed-off-by: Levis Florian > > > --- > > > doc/protocols.texi| 15 +++ > > > libavformat/libamqp.c | 6 +- > > >

Re: [FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

2020-06-20 Thread Florian Levis
That's OK for me -- Florian LEVIS Le sam. 20 juin 2020 à 20:56, Andriy Gelman a écrit : > On Sat, 20. Jun 19:16, Levis Florian wrote: > > Signed-off-by: Levis Florian > > --- > > doc/protocols.texi| 15 +++ > > libavformat/libamqp.c | 6 +- > > 2 files changed, 20 insert

Re: [FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

2020-06-20 Thread Andriy Gelman
On Sat, 20. Jun 19:16, Levis Florian wrote: > Signed-off-by: Levis Florian > --- > doc/protocols.texi| 15 +++ > libavformat/libamqp.c | 6 +- > 2 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/doc/protocols.texi b/doc/protocols.texi > index 7aa758541c..2e15

[FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

2020-06-20 Thread Levis Florian
Signed-off-by: Levis Florian --- doc/protocols.texi| 15 +++ libavformat/libamqp.c | 6 +- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 7aa758541c..2e15925eeb 100644 --- a/doc/protocols.texi +++ b/doc/protocols.t

Re: [FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

2020-06-20 Thread Andriy Gelman
On Sat, 20. Jun 12:28, Florian Levis wrote: > (re-sending, forgot list, sorry Andriy for double sending) > > Hi Andriy, > > > Is the goal of the non-persistent option to reduce disk io, or something > else? > > I ran a quick test to look at disk io, but didn't see a difference. > > TL;DR > -> it

Re: [FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

2020-06-20 Thread Florian Levis
(re-sending, forgot list, sorry Andriy for double sending) Hi Andriy, > Is the goal of the non-persistent option to reduce disk io, or something else? > I ran a quick test to look at disk io, but didn't see a difference. TL;DR -> it have effect on the broker (ex: RabbitMQ) -> it should not have

Re: [FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

2020-06-19 Thread Andriy Gelman
Hi Levis, Thanks for your patch. On Mon, 15. Jun 11:16, Levis Florian wrote: > Signed-off-by: Levis Florian > --- > doc/protocols.texi| 13 + > libavformat/libamqp.c | 6 +- > 2 files changed, 18 insertions(+), 1 deletion(-) > > diff --git a/doc/protocols.texi b/doc/proto

[FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

2020-06-15 Thread Levis Florian
Signed-off-by: Levis Florian --- doc/protocols.texi| 13 + libavformat/libamqp.c | 6 +- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 7aa758541c..336246e67a 100644 --- a/doc/protocols.texi +++ b/doc/protocols.tex

Re: [FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

2020-06-14 Thread Moritz Barsnick
On Sun, Jun 14, 2020 at 18:56:06 +0200, Levis Florian wrote: Small nit: > +{ "delivery_mode", "Delivery more (non-persistent: 1/persistent: 2)", > OFFSET(delivery_mode), AV_OPT_TYPE_INT, { .i64 = AMQP_DELIVERY_PERSISTENT }, > 1, 2, .flags = E, "delivery_mode"},

Re: [FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

2020-06-14 Thread Florian Levis
Hi, To Marton Balint that reviewed my patch: I tried to send fixed patch specify the --in-reply-to option, but I guess it's not the good way to do it, cause I see a new thread on the patchwork (20200614165606.36659-1-levis.flor...@gmail.com) git format-patch -M origin/master -o outgoing/ git

[FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

2020-06-14 Thread Levis Florian
Hi, I hope this reply will go to the correct thread. I reworked my patch after Marton Balint review. * fix: missing documentation * fix: use AV_OPT_TYPE_CONST Signed-off-by: Levis Florian --- doc/protocols.texi| 13 + libavformat/libamqp.c | 6 +- 2 files changed, 18 inser

Re: [FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

2020-06-14 Thread Marton Balint
On Sun, 14 Jun 2020, Levis Florian wrote: Signed-off-by: Levis Florian --- libavformat/libamqp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/libamqp.c b/libavformat/libamqp.c index aaf0e51152..485c0ccc49 100644 --- a/libavformat/libamqp.c +++ b/libavforma

[FFmpeg-devel] [PATCH] avformat: AMQP: add option delivery_mode

2020-06-14 Thread Levis Florian
Signed-off-by: Levis Florian --- libavformat/libamqp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/libamqp.c b/libavformat/libamqp.c index aaf0e51152..485c0ccc49 100644 --- a/libavformat/libamqp.c +++ b/libavformat/libamqp.c @@ -39,6 +39,7 @@ typedef struct