Re: [FFmpeg-devel] [PATCH] avformat/yuv4mpegenc: simplify writing the header

2020-09-20 Thread Jan Ekström
On Thu, Sep 10, 2020 at 3:00 AM James Almer wrote: > > On 9/9/2020 7:54 PM, Michael Niedermayer wrote: > > On Thu, Sep 03, 2020 at 03:55:04PM -0300, James Almer wrote: > >> Actually write it in yuv4_write_header() instead of with the first > >> packet. > >> > >> Signed-off-by: James Almer > >> --

Re: [FFmpeg-devel] [PATCH] avformat/yuv4mpegenc: simplify writing the header

2020-09-09 Thread James Almer
On 9/9/2020 7:54 PM, Michael Niedermayer wrote: > On Thu, Sep 03, 2020 at 03:55:04PM -0300, James Almer wrote: >> Actually write it in yuv4_write_header() instead of with the first >> packet. >> >> Signed-off-by: James Almer >> --- >> libavformat/yuv4mpegenc.c | 35 ++-

Re: [FFmpeg-devel] [PATCH] avformat/yuv4mpegenc: simplify writing the header

2020-09-09 Thread Michael Niedermayer
On Thu, Sep 03, 2020 at 03:55:04PM -0300, James Almer wrote: > Actually write it in yuv4_write_header() instead of with the first > packet. > > Signed-off-by: James Almer > --- > libavformat/yuv4mpegenc.c | 35 ++- > 1 file changed, 14 insertions(+), 21 deletions(

Re: [FFmpeg-devel] [PATCH] avformat/yuv4mpegenc: simplify writing the header

2020-09-03 Thread James Almer
On 9/3/2020 4:16 PM, Paul B Mahol wrote: > On 9/3/20, James Almer wrote: >> Actually write it in yuv4_write_header() instead of with the first >> packet. >> >> Signed-off-by: James Almer >> --- >> libavformat/yuv4mpegenc.c | 35 ++- >> 1 file changed, 14 insertion

Re: [FFmpeg-devel] [PATCH] avformat/yuv4mpegenc: simplify writing the header

2020-09-03 Thread Paul B Mahol
On 9/3/20, James Almer wrote: > Actually write it in yuv4_write_header() instead of with the first > packet. > > Signed-off-by: James Almer > --- > libavformat/yuv4mpegenc.c | 35 ++- > 1 file changed, 14 insertions(+), 21 deletions(-) > Nice catch, LGTM > diff

[FFmpeg-devel] [PATCH] avformat/yuv4mpegenc: simplify writing the header

2020-09-03 Thread James Almer
Actually write it in yuv4_write_header() instead of with the first packet. Signed-off-by: James Almer --- libavformat/yuv4mpegenc.c | 35 ++- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/libavformat/yuv4mpegenc.c b/libavformat/yuv4mpegenc.c inde