Re: [FFmpeg-devel] [PATCH] avformat/wtvdec: Fix reading OLE dates on BE

2021-02-28 Thread Andreas Rheinhardt
Peter Ross: > On Sun, Feb 28, 2021 at 04:01:21AM +0100, Andreas Rheinhardt wrote: >> The WTV demuxer's oledata_to_iso8601 reads a value via avio_rl64 >> and reinterprets it as a double via av_int2double. This does not >> work on big endian systems. So swap it to native endianness before >> av_int2d

Re: [FFmpeg-devel] [PATCH] avformat/wtvdec: Fix reading OLE dates on BE

2021-02-28 Thread Andriy Gelman
On Sun, 28. Feb 04:01, Andreas Rheinhardt wrote: > The WTV demuxer's oledata_to_iso8601 reads a value via avio_rl64 > and reinterprets it as a double via av_int2double. This does not > work on big endian systems. So swap it to native endianness before > av_int2double. > > law-and-order-partial.wtv

Re: [FFmpeg-devel] [PATCH] avformat/wtvdec: Fix reading OLE dates on BE

2021-02-27 Thread Peter Ross
On Sun, Feb 28, 2021 at 04:01:21AM +0100, Andreas Rheinhardt wrote: > The WTV demuxer's oledata_to_iso8601 reads a value via avio_rl64 > and reinterprets it as a double via av_int2double. This does not > work on big endian systems. So swap it to native endianness before > av_int2double. > > law-an

[FFmpeg-devel] [PATCH] avformat/wtvdec: Fix reading OLE dates on BE

2021-02-27 Thread Andreas Rheinhardt
The WTV demuxer's oledata_to_iso8601 reads a value via avio_rl64 and reinterprets it as a double via av_int2double. This does not work on big endian systems. So swap it to native endianness before av_int2double. law-and-order-partial.wtv from the FATE-suite exhibited the problem. Thanks-to: Andri