Re: [FFmpeg-devel] [PATCH] avformat/wavdec: add support for chapters

2020-09-01 Thread Paul B Mahol
On 9/1/20, Anton Khirnov wrote: > Quoting Paul B Mahol (2020-08-31 14:20:11) >> Support parsing 'cue ' and 'adtl' chunks. >> >> Signed-off-by: Paul B Mahol >> --- >> libavformat/wavdec.c | 50 >> 1 file changed, 50 insertions(+) > > Looks ok beyond so

Re: [FFmpeg-devel] [PATCH] avformat/wavdec: add support for chapters

2020-09-01 Thread Anton Khirnov
Quoting Paul B Mahol (2020-08-31 14:20:11) > Support parsing 'cue ' and 'adtl' chunks. > > Signed-off-by: Paul B Mahol > --- > libavformat/wavdec.c | 50 > 1 file changed, 50 insertions(+) Also, FATE tests would be nice. -- Anton Khirnov __

Re: [FFmpeg-devel] [PATCH] avformat/wavdec: add support for chapters

2020-09-01 Thread Anton Khirnov
Quoting Paul B Mahol (2020-08-31 14:20:11) > Support parsing 'cue ' and 'adtl' chunks. > > Signed-off-by: Paul B Mahol > --- > libavformat/wavdec.c | 50 > 1 file changed, 50 insertions(+) Looks ok beyond some nits. > > diff --git a/libavformat/wav

[FFmpeg-devel] [PATCH] avformat/wavdec: add support for chapters

2020-08-31 Thread Paul B Mahol
Support parsing 'cue ' and 'adtl' chunks. Signed-off-by: Paul B Mahol --- libavformat/wavdec.c | 50 1 file changed, 50 insertions(+) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index 5b3c481421..545f04c742 100644 --- a/libavformat/wavde