Re: [FFmpeg-devel] [PATCH] avformat/utils: Fix undefined NULL + 0

2021-02-14 Thread Andreas Rheinhardt
James Almer: > On 2/14/2021 6:28 PM, Andreas Rheinhardt wrote: >> This is undefined behaviour in C, so use data = len ? data + len : data >> instead if data += len. GCC optimizes the branch away in this case; >> Clang unfortunately doesn't. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> Checkin

Re: [FFmpeg-devel] [PATCH] avformat/utils: Fix undefined NULL + 0

2021-02-14 Thread James Almer
On 2/14/2021 6:28 PM, Andreas Rheinhardt wrote: This is undefined behaviour in C, so use data = len ? data + len : data instead if data += len. GCC optimizes the branch away in this case; Clang unfortunately doesn't. Signed-off-by: Andreas Rheinhardt --- Checking for len != 0 instead of > 0 all

Re: [FFmpeg-devel] [PATCH] avformat/utils: Fix undefined NULL + 0

2021-02-14 Thread Paul B Mahol
probably fine ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avformat/utils: Fix undefined NULL + 0

2021-02-14 Thread Andreas Rheinhardt
This is undefined behaviour in C, so use data = len ? data + len : data instead if data += len. GCC optimizes the branch away in this case; Clang unfortunately doesn't. Signed-off-by: Andreas Rheinhardt --- Checking for len != 0 instead of > 0 allows the compiler to optimize the branch away; mayb