[FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/tty.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/libavformat/tty.c b/libavformat/tty.c index 8d48f2c45c..60f7e9f87e 100644 --- a/libavformat/tty.c +++ b/libavformat/tty.c @@ -34,6 +34,13 @@ #include "inter

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Carl Eugen Hoyos
Am Di., 28. Jan. 2020 um 22:28 Uhr schrieb Paul B Mahol : > +static int isansicode(int x) > +{ > +return (x == 0x1B) || (x >= 0x20 && x < 0x7f); I would have expected at least CR and LF, maybe also the tabulator, to be valid characters. Carl Eugen

[FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/tty.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/libavformat/tty.c b/libavformat/tty.c index 8d48f2c45c..69aad64790 100644 --- a/libavformat/tty.c +++ b/libavformat/tty.c @@ -34,6 +34,13 @@ #include "inter

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Nicolas George
Paul B Mahol (12020-01-28): > I certainly could write one which does not use locale, if that is ok with you? You know better than me on this issue. I was just pointing something that may have been forgotten. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Paul B Mahol
On 1/28/20, Nicolas George wrote: > Peter Ross (12020-01-29): >> > +for (int i = 0; i < p->buf_size; i++) >> > +cnt += !!isprint(p->buf[i]); > > This depends on locale settings. Is it on purpose? I certainly could write one which does not use locale, if that is ok with you? > > Regar

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Nicolas George
Peter Ross (12020-01-29): > > +for (int i = 0; i < p->buf_size; i++) > > +cnt += !!isprint(p->buf[i]); This depends on locale settings. Is it on purpose? Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-de

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Peter Ross
On Tue, Jan 28, 2020 at 02:17:35PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/tty.c | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/libavformat/tty.c b/libavformat/tty.c > index 8d48f2c45c..a8fb9dc8f3 100644 > --- a/li

[FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/tty.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/libavformat/tty.c b/libavformat/tty.c index 8d48f2c45c..a8fb9dc8f3 100644 --- a/libavformat/tty.c +++ b/libavformat/tty.c @@ -24,6 +24,8 @@ * Tele-typewriter

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Michael Niedermayer
On Tue, Jan 28, 2020 at 08:17:11AM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/tty.c | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/libavformat/tty.c b/libavformat/tty.c > index 8d48f2c45c..c127500fa1 100644 > --- a/li

[FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-27 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/tty.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/libavformat/tty.c b/libavformat/tty.c index 8d48f2c45c..c127500fa1 100644 --- a/libavformat/tty.c +++ b/libavformat/tty.c @@ -24,6 +24,8 @@ * Tele-typewriter

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-27 Thread James Almer
On 1/27/2020 7:16 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/tty.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/libavformat/tty.c b/libavformat/tty.c > index 8d48f2c45c..75af16a6f1 100644 > --- a/libavformat/tty.c > +++ b/libavformat/tty

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-27 Thread Paul B Mahol
On 1/27/20, Carl Eugen Hoyos wrote: > Am Mo., 27. Jan. 2020 um 23:16 Uhr schrieb Paul B Mahol : >> >> Signed-off-by: Paul B Mahol >> --- >> libavformat/tty.c | 14 ++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/libavformat/tty.c b/libavformat/tty.c >> index 8d48f2c45c..75a

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-27 Thread Carl Eugen Hoyos
Am Mo., 27. Jan. 2020 um 23:16 Uhr schrieb Paul B Mahol : > > Signed-off-by: Paul B Mahol > --- > libavformat/tty.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/libavformat/tty.c b/libavformat/tty.c > index 8d48f2c45c..75af16a6f1 100644 > --- a/libavformat/tty.c > +++

[FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-27 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/tty.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavformat/tty.c b/libavformat/tty.c index 8d48f2c45c..75af16a6f1 100644 --- a/libavformat/tty.c +++ b/libavformat/tty.c @@ -24,6 +24,8 @@ * Tele-typewriter demuxer */ +#in

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-27 Thread Carl Eugen Hoyos
Am Mo., 27. Jan. 2020 um 22:56 Uhr schrieb Paul B Mahol : > > On 1/27/20, Carl Eugen Hoyos wrote: > > Am Mo., 27. Jan. 2020 um 22:44 Uhr schrieb Paul B Mahol : > >> > >> On 1/27/20, Carl Eugen Hoyos wrote: > >> > Am Mo., 27. Jan. 2020 um 22:01 Uhr schrieb Paul B Mahol > >> > : > >> >> > >> >> Sig

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-27 Thread Paul B Mahol
On 1/27/20, Carl Eugen Hoyos wrote: > Am Mo., 27. Jan. 2020 um 22:44 Uhr schrieb Paul B Mahol : >> >> On 1/27/20, Carl Eugen Hoyos wrote: >> > Am Mo., 27. Jan. 2020 um 22:01 Uhr schrieb Paul B Mahol >> > : >> >> >> >> Signed-off-by: Paul B Mahol >> >> --- >> >> libavformat/tty.c | 13 ++

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-27 Thread Carl Eugen Hoyos
Am Mo., 27. Jan. 2020 um 22:44 Uhr schrieb Paul B Mahol : > > On 1/27/20, Carl Eugen Hoyos wrote: > > Am Mo., 27. Jan. 2020 um 22:01 Uhr schrieb Paul B Mahol : > >> > >> Signed-off-by: Paul B Mahol > >> --- > >> libavformat/tty.c | 13 + > >> 1 file changed, 13 insertions(+) > >> > >

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-27 Thread Paul B Mahol
On 1/27/20, Carl Eugen Hoyos wrote: > Am Mo., 27. Jan. 2020 um 22:01 Uhr schrieb Paul B Mahol : >> >> Signed-off-by: Paul B Mahol >> --- >> libavformat/tty.c | 13 + >> 1 file changed, 13 insertions(+) >> >> diff --git a/libavformat/tty.c b/libavformat/tty.c >> index 8d48f2c45c..acc6

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-27 Thread Carl Eugen Hoyos
Am Mo., 27. Jan. 2020 um 22:01 Uhr schrieb Paul B Mahol : > > Signed-off-by: Paul B Mahol > --- > libavformat/tty.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/libavformat/tty.c b/libavformat/tty.c > index 8d48f2c45c..acc6da27cc 100644 > --- a/libavformat/tty.c > +++ b

[FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-27 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/tty.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/tty.c b/libavformat/tty.c index 8d48f2c45c..acc6da27cc 100644 --- a/libavformat/tty.c +++ b/libavformat/tty.c @@ -24,6 +24,8 @@ * Tele-typewriter demuxer */ +#inc