Re: [FFmpeg-devel] [PATCH] avformat/srtdec: give WebVTT priority

2015-10-09 Thread Clément Bœsch
On Thu, Oct 08, 2015 at 11:51:32PM +0200, wm4 wrote: > On Thu, 8 Oct 2015 19:40:38 +0200 > wm4 wrote: > > > WevVTT and SRT can look very similar. For some samples, they both > > succeed and return AVPROBE_SCORE_MAX, which leads to probing failure. > > > > This gives priority to WebVTT in ambigu

Re: [FFmpeg-devel] [PATCH] avformat/srtdec: give WebVTT priority

2015-10-08 Thread wm4
On Thu, 8 Oct 2015 19:40:38 +0200 wm4 wrote: > WevVTT and SRT can look very similar. For some samples, they both > succeed and return AVPROBE_SCORE_MAX, which leads to probing failure. > > This gives priority to WebVTT in ambiguous cases. Since WebVTT only > succeeds if the header is present, i

Re: [FFmpeg-devel] [PATCH] avformat/srtdec: give WebVTT priority

2015-10-08 Thread Clément Bœsch
On Thu, Oct 08, 2015 at 07:40:38PM +0200, wm4 wrote: > WevVTT and SRT can look very similar. For some samples, they both > succeed and return AVPROBE_SCORE_MAX, which leads to probing failure. > oO Can I see a sample that this commit fixes? > This gives priority to WebVTT in ambiguous cases. Si

[FFmpeg-devel] [PATCH] avformat/srtdec: give WebVTT priority

2015-10-08 Thread wm4
WevVTT and SRT can look very similar. For some samples, they both succeed and return AVPROBE_SCORE_MAX, which leads to probing failure. This gives priority to WebVTT in ambiguous cases. Since WebVTT only succeeds if the header is present, it's pretty sure WebVTT should win in these cases. --- lib