Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: forward rw_timeout to tcp proto

2023-07-20 Thread Timo Rothenpieler
On 20.07.2023 23:09, Martin Storsjö wrote: Hmm, geez we have many similar-looking and randomly named timeout options here... The av_opt_copy() call in ffurl_open_whitelist() should only iterate over the options within the URLContext itself, not recurse into the protocol private options (as th

Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: forward rw_timeout to tcp proto

2023-07-20 Thread Martin Storsjö
On Thu, 20 Jul 2023, Timo Rothenpieler wrote: On 20.07.2023 22:47, Martin Storsjö wrote: On Thu, 20 Jul 2023, Timo Rothenpieler wrote: --- libavformat/rtmpproto.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Hmm, I would have somewhat expected that rw_timeout should be ho

Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: forward rw_timeout to tcp proto

2023-07-20 Thread Timo Rothenpieler
On 20.07.2023 22:47, Martin Storsjö wrote: On Thu, 20 Jul 2023, Timo Rothenpieler wrote: --- libavformat/rtmpproto.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Hmm, I would have somewhat expected that rw_timeout should be honored here already... Note that URLContext al

Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: forward rw_timeout to tcp proto

2023-07-20 Thread Martin Storsjö
On Thu, 20 Jul 2023, Timo Rothenpieler wrote: --- libavformat/rtmpproto.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Hmm, I would have somewhat expected that rw_timeout should be honored here already... Note that URLContext already has got a rw_timeout field and AVOptio

[FFmpeg-devel] [PATCH] avformat/rtmpproto: forward rw_timeout to tcp proto

2023-07-20 Thread Timo Rothenpieler
--- libavformat/rtmpproto.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index f0ef223f05..a18cc78eac 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -127,6 +127,7 @@ typedef struct RTMPContex