Re: [FFmpeg-devel] [PATCH] avformat/mp3: skip junk at the beginning of mp3 files

2015-05-27 Thread Michael Niedermayer
On Wed, May 27, 2015 at 02:48:10PM +0200, wm4 wrote: > Apparently it can happen that a mp3 file has junk data between id3 tag > and actual mp3 data. Skip this to avoid outputting nonsense timestamps. > (Two packets had the same timestamps, because the mp3 parser failed to > compute a frame duration

Re: [FFmpeg-devel] [PATCH] avformat/mp3: skip junk at the beginning of mp3 files

2015-05-27 Thread wm4
On Wed, 27 May 2015 13:15:12 + (UTC) Carl Eugen Hoyos wrote: > wm4 googlemail.com> writes: > > > +av_log(s, AV_LOG_INFO, "Skipping %d bytes > > of junk at %lld.\n", i, (long long)off); > > The cast should not be necessary, use "PRId64". > (It is currently only used in out-comm

Re: [FFmpeg-devel] [PATCH] avformat/mp3: skip junk at the beginning of mp3 files

2015-05-27 Thread Carl Eugen Hoyos
wm4 googlemail.com> writes: > +av_log(s, AV_LOG_INFO, "Skipping %d bytes > of junk at %lld.\n", i, (long long)off); The cast should not be necessary, use "PRId64". (It is currently only used in out-commented code in the libraries afaict.) Carl Eugen __

[FFmpeg-devel] [PATCH] avformat/mp3: skip junk at the beginning of mp3 files

2015-05-27 Thread wm4
Apparently it can happen that a mp3 file has junk data between id3 tag and actual mp3 data. Skip this to avoid outputting nonsense timestamps. (Two packets had the same timestamps, because the mp3 parser failed to compute a frame duration.) In this case, the junk consisted of 1044 bytes of zero, w