Re: [FFmpeg-devel] [PATCH] avformat/movenc: write the colr atom by default

2020-08-21 Thread Michael Bradshaw
On Wed, Aug 19, 2020 at 2:19 PM Paul B Mahol wrote: > On 8/19/20, Michael Bradshaw wrote: > > I completely forgot about this patch. If no one objects over the next few > > days I plan on pushing this. FATE still passes. > > Fine by me. Thanks. Pushed. __

Re: [FFmpeg-devel] [PATCH] avformat/movenc: write the colr atom by default

2020-08-19 Thread Paul B Mahol
On 8/19/20, Michael Bradshaw wrote: > On Mon, Apr 13, 2020 at 4:14 PM Michael Bradshaw wrote: > >> Attached is an updated patch that passes fate. >> > > I completely forgot about this patch. If no one objects over the next few > days I plan on pushing this. FATE still passes. Fine by me. ___

Re: [FFmpeg-devel] [PATCH] avformat/movenc: write the colr atom by default

2020-08-19 Thread Michael Bradshaw
On Mon, Apr 13, 2020 at 4:14 PM Michael Bradshaw wrote: > Attached is an updated patch that passes fate. > I completely forgot about this patch. If no one objects over the next few days I plan on pushing this. FATE still passes. ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH] avformat/movenc: write the colr atom by default

2020-04-13 Thread Michael Bradshaw
Attached is an updated patch that passes fate. 0001-avformat-movenc-write-the-colr-atom-by-default.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, vis

Re: [FFmpeg-devel] [PATCH] avformat/movenc: write the colr atom by default

2020-04-13 Thread Michael Bradshaw
At the risk of being too non-committal, attached patch is mostly the same but leaves the write_colr flag as experimental. I would love to remove the write_colr flag entirely but we should provide some kind of escape hatch to allow ffmpeg to write "unspecified" (enum value 2) values for the colr ato

Re: [FFmpeg-devel] [PATCH] avformat/movenc: write the colr atom by default

2020-03-30 Thread Michael Bradshaw
On Mon, Mar 30, 2020 at 3:46 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Why is all this information not in the commit message? (In commit > message style of course, i.e. no "I propose".) For reasons that I'm happy to discuss in a separate thread to avoid derailing this one. A

Re: [FFmpeg-devel] [PATCH] avformat/movenc: write the colr atom by default

2020-03-30 Thread Andreas Rheinhardt
Michael Bradshaw: > The write_colr flag has been marked as experimental for over 5 years. I > propose we do the following (as implemented by the attached patch): > >- Write the colr atom by default for mp4/mov if any of the following: > - The primaries/trc/matrix are all specified, OR >

[FFmpeg-devel] [PATCH] avformat/movenc: write the colr atom by default

2020-03-30 Thread Michael Bradshaw
The write_colr flag has been marked as experimental for over 5 years. I propose we do the following (as implemented by the attached patch): - Write the colr atom by default for mp4/mov if any of the following: - The primaries/trc/matrix are all specified, OR - There is an ICC profil