Re: [FFmpeg-devel] [PATCH] avformat/movenc: read track title from correct key

2018-06-18 Thread Gyan Doshi
On 18-06-2018 11:17 PM, John Stebbins wrote: Will push in a day as-is if there are no objections. No objections from me.  Was only making sure you had full information about the history of this code. Pushed. Regards, Gyan ___ ffmpeg-devel ma

Re: [FFmpeg-devel] [PATCH] avformat/movenc: read track title from correct key

2018-06-18 Thread John Stebbins
On 06/18/2018 07:30 AM, Gyan Doshi wrote: > > On 17-06-2018 10:07 AM, Gyan Doshi wrote: > >>> Just need to make a note to myself to fix HandBrake when we >>> update to a version of ffmpeg with the change. >> I can just use an if-else to check for both, giving priority to 'handler'. > When I wrote

Re: [FFmpeg-devel] [PATCH] avformat/movenc: read track title from correct key

2018-06-18 Thread Gyan Doshi
On 17-06-2018 10:07 AM, Gyan Doshi wrote: Just need to make a note to myself to fix HandBrake when we update to a version of ffmpeg with the change. I can just use an if-else to check for both, giving priority to 'handler'. When I wrote the above, I didn't realize that Handbrake had alread

Re: [FFmpeg-devel] [PATCH] avformat/movenc: read track title from correct key

2018-06-16 Thread Gyan Doshi
On 17-06-2018 01:23 AM, John Stebbins wrote: On 06/16/2018 03:49 AM, Gyan Doshi wrote: Activates functionality added a few years ago. Regards, Gyan FYI, HandBrake has been using the "handler" metadata key since 2014 when I added this code.  And it was completely self-consistent (since it

Re: [FFmpeg-devel] [PATCH] avformat/movenc: read track title from correct key

2018-06-16 Thread John Stebbins
On 06/16/2018 03:49 AM, Gyan Doshi wrote: > Activates functionality added a few years ago. > > Regards, > Gyan > FYI, HandBrake has been using the "handler" metadata key since 2014 when I added this code.  And it was completely self-consistent (since it was the only occurrence of usage of this k

[FFmpeg-devel] [PATCH] avformat/movenc: read track title from correct key

2018-06-16 Thread Gyan Doshi
Activates functionality added a few years ago. Regards, Gyan From bead9f22630f2b8efc4a3859568cb0fc46102dd3 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sat, 16 Jun 2018 15:31:51 +0530 Subject: [PATCH] avformat/movenc: read track title from correct key da9cc22d5bd allowed the MOV muxer to rel