Re: [FFmpeg-devel] [PATCH] avformat/mov: Propagate errors in mov_switch_root.

2017-11-20 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 12:05:02PM -0800, Jacob Trimble wrote: > Signed-off-by: Jacob Trimble > --- > libavformat/mov.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No human bein

[FFmpeg-devel] [PATCH] avformat/mov: Propagate errors in mov_switch_root.

2017-11-20 Thread Jacob Trimble
Signed-off-by: Jacob Trimble --- libavformat/mov.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 0b8f8ad24b..b6cdf3a52a 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -6753,6 +6753,7 @@ static int should_retry(AVI

Re: [FFmpeg-devel] [PATCH] avformat/mov: Propagate errors in mov_switch_root.

2017-11-17 Thread Moritz Barsnick
On Thu, Nov 16, 2017 at 16:28:22 -0800, Jacob Trimble wrote: > -if (mov_read_default(mov, s->pb, (MOVAtom){ AV_RL32("root"), INT64_MAX > }) < 0 || > -avio_feof(s->pb)) > +if ((ret = mov_read_default(mov, s->pb, (MOVAtom){ AV_RL32("root"), > INT64_MAX })) < 0) > +return ret

Re: [FFmpeg-devel] [PATCH] avformat/mov: Propagate errors in mov_switch_root.

2017-11-16 Thread Derek Buitenhuis
On 11/17/2017 12:28 AM, Jacob Trimble wrote: > Signed-off-by: Jacob Trimble > --- > libavformat/mov.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Looks OK. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.o

[FFmpeg-devel] [PATCH] avformat/mov: Propagate errors in mov_switch_root.

2017-11-16 Thread Jacob Trimble
Signed-off-by: Jacob Trimble --- libavformat/mov.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d49d820d2b..c5f07595df 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -6747,6 +6747,7 @@ static int should_retry(AVIO