Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2022-10-25 Thread Andreas Rheinhardt
Mohammad Izadi: > The fate test file can be found here: > https://drive.google.com/file/d/1jGW3f94rglLfr5WGmMQe3SEnp1YkbMRy/view?usp=drivesdk > The video file needs to be copied to fate-suite/mkv/ This does not describe the patch at all and should therefore not be part of the commit message. > -

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2022-10-25 Thread Mohammad Izadi
Michael, I appreciate it if you can take a look and give me your feedback. Thanks, Mohammad On Thu, Sep 8, 2022 at 10:03 AM Mohammad Izadi wrote: > Michael, I appreciate it if you can take a look and give me your feedback. > > > On Thu, Sep 8, 2022 at 9:31 AM Michael Niedermayer > wrote: > >>

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2022-09-08 Thread Mohammad Izadi
Michael, I appreciate it if you can take a look and give me your feedback. On Thu, Sep 8, 2022 at 9:31 AM Michael Niedermayer wrote: > On Wed, Sep 07, 2022 at 02:12:46PM +0100, Derek Buitenhuis wrote: > > On 9/6/2022 10:47 PM, Mohammad Izadi wrote: > > > +if (side_data && side_data_size > 0

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2022-09-08 Thread Michael Niedermayer
On Wed, Sep 07, 2022 at 02:12:46PM +0100, Derek Buitenhuis wrote: > On 9/6/2022 10:47 PM, Mohammad Izadi wrote: > > +if (side_data && side_data_size > 0) > > + > > ff_write_dynamic_hdr10_plus_to_full_itu_t_t35((AVDynamicHDRPlus*)side_data, > > &hdr10_plus_itu_t_t35, &hdr10_plus_itu_t_t

[FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2022-09-07 Thread Mohammad Izadi
The fate test file can be found here: https://drive.google.com/file/d/1jGW3f94rglLfr5WGmMQe3SEnp1YkbMRy/view?usp=drivesdk The video file needs to be copied to fate-suite/mkv/ --- libavcodec/dynamic_hdr10_plus.c | 269 +--- libavcodec/dynamic_hdr10_plus.h |

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2022-09-07 Thread Mohammad Izadi
Thank you Derek for your comment ! It’s fixed. On Wed, Sep 7, 2022 at 6:13 AM Derek Buitenhuis wrote: > On 9/6/2022 10:47 PM, Mohammad Izadi wrote: > > +if (side_data && side_data_size > 0) > > + > ff_write_dynamic_hdr10_plus_to_full_itu_t_t35((AVDynamicHDRPlus*)side_data, > &hdr10_plus_itu

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2022-09-07 Thread Derek Buitenhuis
On 9/6/2022 10:47 PM, Mohammad Izadi wrote: > +if (side_data && side_data_size > 0) > + > ff_write_dynamic_hdr10_plus_to_full_itu_t_t35((AVDynamicHDRPlus*)side_data, > &hdr10_plus_itu_t_t35, &hdr10_plus_itu_t_t35_size); You can't use ff_-prefixed functions across library boundaries.

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2022-09-06 Thread Michael Niedermayer
On Tue, Sep 06, 2022 at 09:47:04PM +, Mohammad Izadi wrote: > The fate test file can be found here: > https://drive.google.com/file/d/1jGW3f94rglLfr5WGmMQe3SEnp1YkbMRy/view?usp=drivesdk > The video file needs to be copied to fate-suite/mkv/ > --- > libavcodec/dynamic_hdr10_plus.c

[FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2022-09-06 Thread Mohammad Izadi
The fate test file can be found here: https://drive.google.com/file/d/1jGW3f94rglLfr5WGmMQe3SEnp1YkbMRy/view?usp=drivesdk The video file needs to be copied to fate-suite/mkv/ --- libavcodec/dynamic_hdr10_plus.c | 269 +--- libavcodec/dynamic_hdr10_plus.h |

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2022-04-17 Thread Michael Niedermayer
On Wed, Mar 30, 2022 at 04:22:23PM -0700, Mohammad Izadi wrote: > From: Gyan Doshi > > The fate test file can be found here: > https://drive.google.com/file/d/1jGW3f94rglLfr5WGmMQe3SEnp1YkbMRy/view?usp=drivesdk > The video file needs to be copied to fate-suite/mkv/ > --- > libavcodec/dynamic_hd

[FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2022-03-30 Thread Mohammad Izadi
From: Gyan Doshi The fate test file can be found here: https://drive.google.com/file/d/1jGW3f94rglLfr5WGmMQe3SEnp1YkbMRy/view?usp=drivesdk The video file needs to be copied to fate-suite/mkv/ --- libavcodec/dynamic_hdr10_plus.c | 269 +--- libavcodec/dynamic_hdr10_pl

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2021-08-18 Thread Gyan Doshi
On 2021-08-19 04:53 am, Mohammad Izadi wrote: On Tue, Aug 17, 2021 at 9:41 PM Gyan Doshi wrote: On 2021-08-18 04:10 am, Mohammad Izadi wrote: From: Gyan Doshi Can you refresh my memory on how I'm involved? Don't know. Sent to ffmpeg-devel@ffmpeg.org. Then remove it from the commit m

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2021-08-18 Thread Mohammad Izadi
On Tue, Aug 17, 2021 at 9:41 PM Gyan Doshi wrote: > > > On 2021-08-18 04:10 am, Mohammad Izadi wrote: > > From: Gyan Doshi > > Can you refresh my memory on how I'm involved? > Don't know. Sent to ffmpeg-devel@ffmpeg.org. > > > > > The fate test file can be found here: > https://drive.google.com

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2021-08-18 Thread Michael Niedermayer
On Tue, Aug 17, 2021 at 03:40:28PM -0700, Mohammad Izadi wrote: > From: Gyan Doshi > > The fate test file can be found here: > https://drive.google.com/file/d/1jGW3f94rglLfr5WGmMQe3SEnp1YkbMRy/view?usp=drivesdk > The video file needs to be copied to fate-suite/mkv/ > --- > libavcodec/dynamic_hd

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2021-08-17 Thread Gyan Doshi
On 2021-08-18 04:10 am, Mohammad Izadi wrote: From: Gyan Doshi Can you refresh my memory on how I'm involved? The fate test file can be found here: https://drive.google.com/file/d/1jGW3f94rglLfr5WGmMQe3SEnp1YkbMRy/view?usp=drivesdk The video file needs to be copied to fate-suite/mkv/ ---

[FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska.

2021-08-17 Thread Mohammad Izadi
From: Gyan Doshi The fate test file can be found here: https://drive.google.com/file/d/1jGW3f94rglLfr5WGmMQe3SEnp1YkbMRy/view?usp=drivesdk The video file needs to be copied to fate-suite/mkv/ --- libavcodec/dynamic_hdr10_plus.c | 273 +--- libavcodec/dynamic_hdr10_pl