Re: [FFmpeg-devel] [PATCH] avformat/http: Fix leak when using deprecated option

2021-03-06 Thread Marton Balint
On Sat, 6 Mar 2021, Andreas Rheinhardt wrote: Marton Balint: On Sat, 6 Mar 2021, Andreas Rheinhardt wrote: When the deprecated option "user-agent" was set to something different than its default value, said option would always precede and overwrite the ordinary user_agent option (regardle

Re: [FFmpeg-devel] [PATCH] avformat/http: Fix leak when using deprecated option

2021-03-06 Thread Andreas Rheinhardt
Marton Balint: > > > On Sat, 6 Mar 2021, Andreas Rheinhardt wrote: > >> When the deprecated option "user-agent" was set to something different >> than its default value, said option would always precede and overwrite >> the ordinary user_agent option (regardless of whether it was explicitly >> s

Re: [FFmpeg-devel] [PATCH] avformat/http: Fix leak when using deprecated option

2021-03-06 Thread Andreas Rheinhardt
James Almer: > On 3/6/2021 1:57 PM, Marton Balint wrote: >> >> >> On Sat, 6 Mar 2021, Andreas Rheinhardt wrote: >> >>> When the deprecated option "user-agent" was set to something different >>> than its default value, said option would always precede and overwrite >>> the ordinary user_agent option

Re: [FFmpeg-devel] [PATCH] avformat/http: Fix leak when using deprecated option

2021-03-06 Thread James Almer
On 3/6/2021 1:57 PM, Marton Balint wrote: On Sat, 6 Mar 2021, Andreas Rheinhardt wrote: When the deprecated option "user-agent" was set to something different than its default value, said option would always precede and overwrite the ordinary user_agent option (regardless of whether it was ex

Re: [FFmpeg-devel] [PATCH] avformat/http: Fix leak when using deprecated option

2021-03-06 Thread Marton Balint
On Sat, 6 Mar 2021, Andreas Rheinhardt wrote: When the deprecated option "user-agent" was set to something different than its default value, said option would always precede and overwrite the ordinary user_agent option (regardless of whether it was explicitly set) which leads to a leak of the

[FFmpeg-devel] [PATCH] avformat/http: Fix leak when using deprecated option

2021-03-06 Thread Andreas Rheinhardt
When the deprecated option "user-agent" was set to something different than its default value, said option would always precede and overwrite the ordinary user_agent option (regardless of whether it was explicitly set) which leads to a leak of the user_agent option (which has a default value, so th