Re: [FFmpeg-devel] [PATCH] avformat/flvdec: enhance parsing timestamps

2021-05-14 Thread Marton Balint
On Fri, 14 May 2021, Anton Khirnov wrote: Quoting Marton Balint (2021-05-12 20:55:45) Take into account timezone. Use millisecond precision. Maybe we could also use nanosecond, but there were some float rounding concerns. Signed-off-by: Marton Balint --- libavformat/flvdec.c | 13 ++--

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: enhance parsing timestamps

2021-05-14 Thread Anton Khirnov
Quoting Marton Balint (2021-05-12 20:55:45) > Take into account timezone. Use millisecond precision. Maybe we could also use > nanosecond, but there were some float rounding concerns. > > Signed-off-by: Marton Balint > --- > libavformat/flvdec.c | 13 ++--- > tests/ref/fate/flv-demux

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: enhance parsing timestamps

2021-05-12 Thread Marton Balint
On Wed, 12 May 2021, James Almer wrote: On 5/12/2021 3:55 PM, Marton Balint wrote: Take into account timezone. Use millisecond precision. Maybe we could also use nanosecond, but there were some float rounding concerns. Alexander Strasser wrote an alternative approach to using timezone in

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: enhance parsing timestamps

2021-05-12 Thread James Almer
On 5/12/2021 3:55 PM, Marton Balint wrote: Take into account timezone. Use millisecond precision. Maybe we could also use nanosecond, but there were some float rounding concerns. Alexander Strasser wrote an alternative approach to using timezone in https://lists.ffmpeg.org/pipermail/ffmpeg-dev

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: enhance parsing timestamps

2021-05-12 Thread James Almer
On 5/12/2021 4:04 PM, James Almer wrote: On 5/12/2021 3:55 PM, Marton Balint wrote: Take into account timezone. Use millisecond precision. Maybe we could also use nanosecond, but there were some float rounding concerns. Alexander Strasser wrote an alternative approach to using timezone in ht

[FFmpeg-devel] [PATCH] avformat/flvdec: enhance parsing timestamps

2021-05-12 Thread Marton Balint
Take into account timezone. Use millisecond precision. Maybe we could also use nanosecond, but there were some float rounding concerns. Signed-off-by: Marton Balint --- libavformat/flvdec.c | 13 ++--- tests/ref/fate/flv-demux | 2 +- 2 files changed, 3 insertions(+), 12 deletions(-