On Sun, Oct 04, 2015 at 01:50:45PM +0800, Ching-Yi Chan wrote:
> 2015-10-04 7:37 GMT+08:00 Michael Niedermayer :
>
> > On Sat, Oct 03, 2015 at 01:14:26AM +0800, Ching-Yi Chan wrote:
> >
> > iam not sure changing the format flags is a great idea, i think no
> > other demuxer does that
> > that said
2015-10-04 7:37 GMT+08:00 Michael Niedermayer :
> On Sat, Oct 03, 2015 at 01:14:26AM +0800, Ching-Yi Chan wrote:
>
> iam not sure changing the format flags is a great idea, i think no
> other demuxer does that
> that said, the documentation does not say that only the user can
> change them so this
On Sun, Oct 4, 2015 at 1:37 AM, Michael Niedermayer wrote:
> On Sat, Oct 03, 2015 at 01:14:26AM +0800, Ching-Yi Chan wrote:
>> Here is a new patch:
>>
>> 1. fix compilation warning
>> 2. remove ff_ prefix on my patch
>> 3. toggle AVFMT_FLAG_FAST_SEEK when no seektalbe in the flac metadata (this
>>
On Sat, Oct 03, 2015 at 01:14:26AM +0800, Ching-Yi Chan wrote:
> Here is a new patch:
>
> 1. fix compilation warning
> 2. remove ff_ prefix on my patch
> 3. toggle AVFMT_FLAG_FAST_SEEK when no seektalbe in the flac metadata (this
> will disable flac_seek when no seekpoint)
> flacdec.c | 59 +++
Here is a new patch:
1. fix compilation warning
2. remove ff_ prefix on my patch
3. toggle AVFMT_FLAG_FAST_SEEK when no seektalbe in the flac metadata (this
will disable flac_seek when no seekpoint)
0001-avformat-flacdec-support-fast-seek.patch
Description: Binary data
__
Le primidi 11 vendémiaire, an CCXXIV, wm4 a écrit :
> > 3. use a static varible to keep the state in flacdec.c
> No global mutable state anywhere in the libs.
For once, I fully agree, but even without that principle, it would be wrong,
since an application can have several FLAC files open simultan
On Fri, 2 Oct 2015 21:56:22 +0800
Ching-Yi Chan wrote:
> I found the problem is no seektable in our test sample acodec-flac.flac,
> but application will append the new index entry to AVStream.
>
> So, I need to a variable or some place to mark "no seektable, don't use
> fast-seek method", some c
I found the problem is no seektable in our test sample acodec-flac.flac,
but application will append the new index entry to AVStream.
So, I need to a variable or some place to mark "no seektable, don't use
fast-seek method", some choices:
1. disable AVFMT_FLAG_FAST_SEEK flag when no seektable
2.
Ching-Yi Chan gmail.com> writes:
> May I have a copy about the tests code. for improving my patch.
$ make V=1 fate-seek-acodec-flac
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
2015-10-01 20:31 GMT+08:00 Michael Niedermayer :
> On Fri, Sep 25, 2015 at 11:58:31AM +0800, Ching-Yi Chan wrote:
> > Thanks for checking.
> >
> > I also check the AVFMT_FLAG_FAST_SEEK flag with parsing headers,
> > to fill the seektable into index entries only if AVFMT_FLAG_FAST_SEEK
> flag
> > i
On Fri, Sep 25, 2015 at 11:58:31AM +0800, Ching-Yi Chan wrote:
> Thanks for checking.
>
> I also check the AVFMT_FLAG_FAST_SEEK flag with parsing headers,
> to fill the seektable into index entries only if AVFMT_FLAG_FAST_SEEK flag
> is on.
>
> If the AVFMT_FLAG_FAST_SEEK flag is not enabled, it
Thanks for checking.
I also check the AVFMT_FLAG_FAST_SEEK flag with parsing headers,
to fill the seektable into index entries only if AVFMT_FLAG_FAST_SEEK flag
is on.
If the AVFMT_FLAG_FAST_SEEK flag is not enabled, it will seek in original
way.
2015-09-25 10:37 GMT+08:00 Michael Niedermayer :
On Fri, Sep 25, 2015 at 09:22:41AM +0800, Ching-Yi Chan wrote:
> I do it with AVFMT_FLAG_FAST_SEEK flag.
>
>
> 2015-09-24 23:47 GMT+08:00 wm4 :
>
> > On Thu, 24 Sep 2015 23:41:03 +0800
> > Ching-Yi Chan wrote:
> >
> > > Is it acceptable to provide an option for different methods
> > > between a
I do it with AVFMT_FLAG_FAST_SEEK flag.
2015-09-24 23:47 GMT+08:00 wm4 :
> On Thu, 24 Sep 2015 23:41:03 +0800
> Ching-Yi Chan wrote:
>
> > Is it acceptable to provide an option for different methods
> > between accuracy seek and fast but inaccurate.
> >
> > For example, mp3dec having "usetoc" o
On Thu, 24 Sep 2015 23:41:03 +0800
Ching-Yi Chan wrote:
> Is it acceptable to provide an option for different methods
> between accuracy seek and fast but inaccurate.
>
> For example, mp3dec having "usetoc" option to seek by toc.
You could use the AVFMT_FLAG_FAST_SEEK flag. (It's a flag set on
Is it acceptable to provide an option for different methods
between accuracy seek and fast but inaccurate.
For example, mp3dec having "usetoc" option to seek by toc.
2015-09-24 22:02 GMT+08:00 Hendrik Leppkes :
> On Thu, Sep 24, 2015 at 2:44 PM, Ching-Yi Chan
> wrote:
> > I found the generi
On Thu, Sep 24, 2015 at 2:44 PM, Ching-Yi Chan wrote:
> I found the generic seek will invoke the flac_read_timestamp function.
> It read exta packet will slow down the seek time
> https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/flacdec.c#L224
>
>
It does that to get to an accurate seek p
I found the generic seek will invoke the flac_read_timestamp function.
It read exta packet will slow down the seek time
https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/flacdec.c#L224
2015-09-24 17:27 GMT+08:00 Ching-Yi Chan :
> Hi Hendrik,
>
> I move the index data into AVStream, but s
Hi Hendrik,
I move the index data into AVStream, but seeking is slow. (it try to
download many data).
Is there something wrong ?
2015-09-24 16:09 GMT+08:00 Hendrik Leppkes :
> On Thu, Sep 24, 2015 at 9:08 AM, Ching-Yi Chan
> wrote:
> > flacdec is not supported fast-seek yet.
> >
> > changes:
>
On Thu, 24 Sep 2015 15:08:06 +0800
Ching-Yi Chan wrote:
> flacdec is not supported fast-seek yet.
>
> changes:
>
> 1. parse the seekpoint from metadata block
> 2. add seek callback to look up seek position
It would be great if we could run our new fate seek tests on this.
(Though I'm not sure
On Thu, Sep 24, 2015 at 9:08 AM, Ching-Yi Chan wrote:
> flacdec is not supported fast-seek yet.
>
> changes:
>
> 1. parse the seekpoint from metadata block
> 2. add seek callback to look up seek position
>
You should store the index in the AVStream index_entries field, that
way you don't need to
flacdec is not supported fast-seek yet.
changes:
1. parse the seekpoint from metadata block
2. add seek callback to look up seek position
0001-avformat-flacdec-support-fast-seek.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel
22 matches
Mail list logo
