Re: [FFmpeg-devel] [PATCH] avformat/file: Fix handing of file URIs

2022-11-24 Thread Nick Sarnie
Okay, thanks. I tried asking if this patch would be accepted in IRC before posting this to prevent this kind of situation but nobody responded. I don't know enough about the codebase to implement the suggested solution, so I'll let you all decide if you want to do it. ___

Re: [FFmpeg-devel] [PATCH] avformat/file: Fix handing of file URIs

2022-11-24 Thread Nicolas George
Nick Sarnie (12022-11-24): > The current URI handling only removes the file: prefix, but we also need to > consider the case of percent encoding. > Percent encoding can happen with non-ASCII characters in the path. NAK, this is a huge compatibility break. But this fix is necessary, you are right.

[FFmpeg-devel] [PATCH] avformat/file: Fix handing of file URIs

2022-11-24 Thread Nick Sarnie
The current URI handling only removes the file: prefix, but we also need to consider the case of percent encoding. Percent encoding can happen with non-ASCII characters in the path. I hit this through mpv with vobsub subtitles when dragging subtitles onto the player using the mouse. Vobsub uses