Re: [FFmpeg-devel] [PATCH] avformat/dhav: Limit get_duration() iterations

2021-11-15 Thread Derek Buitenhuis
On 11/15/2021 3:04 PM, Michael Niedermayer wrote: > i dont like it either > do you have a better idea ? Why is it seaching like this anyway? This is not even the only place in dhav.c it does this. Is the format documented somewhere by chance? There has to be a better early termination condition

Re: [FFmpeg-devel] [PATCH] avformat/dhav: Limit get_duration() iterations

2021-11-15 Thread Michael Niedermayer
On Sun, Nov 14, 2021 at 07:36:59PM +, Kieran Kunhya wrote: > > diff --git a/libavformat/dhav.c b/libavformat/dhav.c > > index b6bb25204c2..6c1cdde32c9 100644 > > --- a/libavformat/dhav.c > > +++ b/libavformat/dhav.c > > @@ -234,12 +234,13 @@ static int64_t get_duration(AVFormatContext *s) > >

Re: [FFmpeg-devel] [PATCH] avformat/dhav: Limit get_duration() iterations

2021-11-14 Thread Michael Niedermayer
On Sun, Oct 17, 2021 at 04:09:09PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 39971/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5756969890217984 > Fixes: > 39977/clusterfuzz-testcase-minimized-ffmpeg_dem_DHAV_fuzzer-5327123053674496 > > Found-by: continuous fuzzing

[FFmpeg-devel] [PATCH] avformat/dhav: Limit get_duration() iterations

2021-10-17 Thread Michael Niedermayer
Fixes: Timeout Fixes: 39971/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5756969890217984 Fixes: 39977/clusterfuzz-testcase-minimized-ffmpeg_dem_DHAV_fuzzer-5327123053674496 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off