Re: [FFmpeg-devel] [PATCH] avformat/dhav: Do not evaluate avio_size() multiple times

2025-06-07 Thread Michael Niedermayer
On Sat, Jun 07, 2025 at 05:23:26PM +0100, Derek Buitenhuis wrote: > On 6/7/2025 12:12 AM, Michael Niedermayer wrote: > > Code like FFMIN(MAX_DURATION_BUFFER_SIZE, avio_size(s->pb)) is not safe > > as FFMIN() is a macro and avio_size() is thus evaluated multiple > > times > > > > CC: Justin Ruggles

Re: [FFmpeg-devel] [PATCH] avformat/dhav: Do not evaluate avio_size() multiple times

2025-06-07 Thread Derek Buitenhuis
On 6/7/2025 12:12 AM, Michael Niedermayer wrote: > Code like FFMIN(MAX_DURATION_BUFFER_SIZE, avio_size(s->pb)) is not safe > as FFMIN() is a macro and avio_size() is thus evaluated multiple > times > > CC: Justin Ruggles > Signed-off-by: Michael Niedermayer > --- > libavformat/dhav.c | 7 --

Re: [FFmpeg-devel] [PATCH] avformat/dhav: Do not evaluate avio_size() multiple times

2025-06-06 Thread Michael Niedermayer
On Sat, Jun 07, 2025 at 12:21:43AM +0100, Kieran Kunhya via ffmpeg-devel wrote: > On Sat, 7 Jun 2025, 00:12 Michael Niedermayer, > wrote: > > > Code like FFMIN(MAX_DURATION_BUFFER_SIZE, avio_size(s->pb)) is not safe > > as FFMIN() is a macro and avio_size() is thus evaluated multiple > > times >

Re: [FFmpeg-devel] [PATCH] avformat/dhav: Do not evaluate avio_size() multiple times

2025-06-06 Thread Kieran Kunhya via ffmpeg-devel
On Sat, 7 Jun 2025, 00:12 Michael Niedermayer, wrote: > Code like FFMIN(MAX_DURATION_BUFFER_SIZE, avio_size(s->pb)) is not safe > as FFMIN() is a macro and avio_size() is thus evaluated multiple > times > > CC: Justin Ruggles > Signed-off-by: Michael Niedermayer > --- > libavformat/dhav.c | 7

[FFmpeg-devel] [PATCH] avformat/dhav: Do not evaluate avio_size() multiple times

2025-06-06 Thread Michael Niedermayer
Code like FFMIN(MAX_DURATION_BUFFER_SIZE, avio_size(s->pb)) is not safe as FFMIN() is a macro and avio_size() is thus evaluated multiple times CC: Justin Ruggles Signed-off-by: Michael Niedermayer --- libavformat/dhav.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/