Re: [FFmpeg-devel] [PATCH] avformat/avio: Remove no-op code in url_find_protocol().

2017-07-09 Thread Muhammad Faiz
On Fri, Jul 7, 2017 at 1:32 PM, Muhammad Faiz wrote: > On Fri, Jul 7, 2017 at 11:27 AM, Wan-Teh Chang > wrote: >> Hi Muhammad, >> >> On Thu, Jul 6, 2017 at 7:56 PM, Muhammad Faiz wrote: >>> On Fri, Jul 7, 2017 at 9:18 AM, Wan-Teh Chang >>> wrote: In url_find_protocol(), proto_str is either

Re: [FFmpeg-devel] [PATCH] avformat/avio: Remove no-op code in url_find_protocol().

2017-07-06 Thread Muhammad Faiz
On Fri, Jul 7, 2017 at 11:27 AM, Wan-Teh Chang wrote: > Hi Muhammad, > > On Thu, Jul 6, 2017 at 7:56 PM, Muhammad Faiz wrote: >> On Fri, Jul 7, 2017 at 9:18 AM, Wan-Teh Chang >> wrote: >>> In url_find_protocol(), proto_str is either "file" or a string >>> consisting of only the characters in URL

Re: [FFmpeg-devel] [PATCH] avformat/avio: Remove no-op code in url_find_protocol().

2017-07-06 Thread Wan-Teh Chang
Hi Muhammad, On Thu, Jul 6, 2017 at 7:56 PM, Muhammad Faiz wrote: > On Fri, Jul 7, 2017 at 9:18 AM, Wan-Teh Chang > wrote: >> In url_find_protocol(), proto_str is either "file" or a string >> consisting of only the characters in URL_SCHEME_CHARS, which does not >> include ','. Therefore the strc

Re: [FFmpeg-devel] [PATCH] avformat/avio: Remove no-op code in url_find_protocol().

2017-07-06 Thread Muhammad Faiz
On Fri, Jul 7, 2017 at 9:18 AM, Wan-Teh Chang wrote: > In url_find_protocol(), proto_str is either "file" or a string > consisting of only the characters in URL_SCHEME_CHARS, which does not > include ','. Therefore the strchr(proto_str, ',') call always returns > NULL. > > Note: The code was added

[FFmpeg-devel] [PATCH] avformat/avio: Remove no-op code in url_find_protocol().

2017-07-06 Thread Wan-Teh Chang
In url_find_protocol(), proto_str is either "file" or a string consisting of only the characters in URL_SCHEME_CHARS, which does not include ','. Therefore the strchr(proto_str, ',') call always returns NULL. Note: The code was added in commit 6161c41817f6e53abb3021d67ca0f19def682718. Signed-off-