Re: [FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

2021-05-04 Thread Martin Storsjö
On Tue, 4 May 2021, Steinar H. Gunderson wrote: On Tue, May 04, 2021 at 04:46:29PM +0100, Derek Buitenhuis wrote: Can this not be accomplished outside of FFmpeg, by registering your own I/O callbacks? That would seem to me to be the 'proper' way to do this. More work? Yes. But less hacky. For

Re: [FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

2021-05-04 Thread Steinar H. Gunderson
On Tue, May 04, 2021 at 06:38:41PM +0100, Derek Buitenhuis wrote: > I will say that it is unclear enough to me what the goals and uses are of > the patch that it came off a bit like upstreaming something purely for > personal > use, even if that wasn't intended. Apologies. No offense taken. The b

Re: [FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

2021-05-04 Thread Derek Buitenhuis
On 04/05/2021 18:22, Steinar H. Gunderson wrote: > For a libavformat-using program that does its own transports? Sure, I'm > already doing that in other projects. For anything that wants to use the > ffurl transports -- and in particular, stream from the ffmpeg(1) client? > I don't see how that wou

Re: [FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

2021-05-04 Thread Steinar H. Gunderson
On Tue, May 04, 2021 at 04:46:29PM +0100, Derek Buitenhuis wrote: > Can this not be accomplished outside of FFmpeg, by registering your own I/O > callbacks? That would seem to me to be the 'proper' way to do this. More > work? Yes. But less hacky. For a libavformat-using program that does its own

Re: [FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

2021-05-04 Thread Hendrik Leppkes
On Tue, May 4, 2021 at 5:52 PM Derek Buitenhuis wrote: > > On 03/05/2021 22:05, Steinar H. Gunderson wrote: > > Two reasons: > > > > - As the commit message says, it is desirable to have this on pipe output > > as > >well (Cubemap would like to fork out to FFmpeg to do remuxing etc. for > >

Re: [FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

2021-05-04 Thread Derek Buitenhuis
On 03/05/2021 22:05, Steinar H. Gunderson wrote: > Two reasons: > > - As the commit message says, it is desirable to have this on pipe output as >well (Cubemap would like to fork out to FFmpeg to do remuxing etc. for >it, without having to speak HTTP over the pipe). > - The HTTP layer do

Re: [FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

2021-05-03 Thread Steinar H. Gunderson
On Mon, May 03, 2021 at 10:51:43PM +0200, Marton Balint wrote: > It is quite ugly that you are introducing this in *avio*. Why is this not an > option of HTTP? Two reasons: - As the commit message says, it is desirable to have this on pipe output as well (Cubemap would like to fork out to FFm

Re: [FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

2021-05-03 Thread Marton Balint
On Mon, 3 May 2021, Steinar H. Gunderson wrote: Support wrapping the output format in Metacube, as used by the Cubemap stream reflector (originally designed for VLC). This is nominally meant to run over HTTP, but longer-term would probably also be useful for pipe output as a subprocess of Cub

[FFmpeg-devel] [PATCH] avformat/avio: Add Metacube support

2021-05-03 Thread Steinar H. Gunderson
Support wrapping the output format in Metacube, as used by the Cubemap stream reflector (originally designed for VLC). This is nominally meant to run over HTTP, but longer-term would probably also be useful for pipe output as a subprocess of Cubemap. Integrating with Cubemap instantly gives FFmpeg