Re: [FFmpeg-devel] [PATCH] avformat/avienc: Use AV_STRINGIFY for compile time constant

2020-03-16 Thread Nicolas George
Anton Khirnov (12020-03-16): > Okay, seems it doesn't. I wonder why. Probably something to do with locales. Or just the benefit/costs is not interesting. > But in any case, optimizing error messages for performance rather than > readability seems rather backwards. That's a reasonable stance by i

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Use AV_STRINGIFY for compile time constant

2020-03-16 Thread Anton Khirnov
Quoting Nicolas George (2020-03-16 11:03:41) > Anton Khirnov (12020-03-16): > > I'd think any decent compiler will already make that transformation. > > Profile, don't speculate. gcc doesn't make that optimization for > printf(). > > And no compiler could do it for av_log() anyway. Okay, seems i

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Use AV_STRINGIFY for compile time constant

2020-03-16 Thread Nicolas George
Anton Khirnov (12020-03-16): > I'd think any decent compiler will already make that transformation. Profile, don't speculate. gcc doesn't make that optimization for printf(). And no compiler could do it for av_log() anyway. Regards, -- Nicolas George signature.asc Description: PGP signatur

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Use AV_STRINGIFY for compile time constant

2020-03-16 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-03-14 18:08:45) > Signed-off-by: Andreas Rheinhardt > --- > libavformat/avienc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/avienc.c b/libavformat/avienc.c > index 07e1c3319e..297d5b8964 100644 > --- a/libavformat/avi

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Use AV_STRINGIFY for compile time constant

2020-03-14 Thread Michael Niedermayer
On Sat, Mar 14, 2020 at 06:08:45PM +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/avienc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Man

[FFmpeg-devel] [PATCH] avformat/avienc: Use AV_STRINGIFY for compile time constant

2020-03-14 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/avienc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avienc.c b/libavformat/avienc.c index 07e1c3319e..297d5b8964 100644 --- a/libavformat/avienc.c +++ b/libavformat/avienc.c @@ -268,8 +268,8 @@ static int a