Re: [FFmpeg-devel] [PATCH] avformat/adxdec: check avctx->channels for invalid values

2015-02-26 Thread Michael Niedermayer
On Thu, Feb 26, 2015 at 01:27:34AM +0100, Andreas Cadhalpun wrote: > On 26.02.2015 00:24, Michael Niedermayer wrote: > >On Wed, Feb 25, 2015 at 11:48:33PM +0100, Andreas Cadhalpun wrote: > >>Hi, > >> > >>if avctx->channels is 0 in adx_read_packet, size gets set to 0, > >>av_get_packet sets pkt->dat

Re: [FFmpeg-devel] [PATCH] avformat/adxdec: check avctx->channels for invalid values

2015-02-25 Thread Andreas Cadhalpun
On 26.02.2015 00:24, Michael Niedermayer wrote: On Wed, Feb 25, 2015 at 11:48:33PM +0100, Andreas Cadhalpun wrote: Hi, if avctx->channels is 0 in adx_read_packet, size gets set to 0, av_get_packet sets pkt->data to NULL and then AV_RB16(pkt->data) results in a null pointer dereference. Attache

Re: [FFmpeg-devel] [PATCH] avformat/adxdec: check avctx->channels for invalid values

2015-02-25 Thread Michael Niedermayer
On Wed, Feb 25, 2015 at 11:48:33PM +0100, Andreas Cadhalpun wrote: > Hi, > > if avctx->channels is 0 in adx_read_packet, size gets set to 0, > av_get_packet sets pkt->data to NULL and then AV_RB16(pkt->data) > results in a null pointer dereference. > > Attached patch fixes this. > > Best regards

[FFmpeg-devel] [PATCH] avformat/adxdec: check avctx->channels for invalid values

2015-02-25 Thread Andreas Cadhalpun
Hi, if avctx->channels is 0 in adx_read_packet, size gets set to 0, av_get_packet sets pkt->data to NULL and then AV_RB16(pkt->data) results in a null pointer dereference. Attached patch fixes this. Best regards, Andreas >From 2578976a0a9eec03d168f393795119fd274ee81f Mon Sep 17 00:00:00 2001