Re: [FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-24 Thread Michael Niedermayer
On Fri, Mar 24, 2017 at 01:49:16PM +0100, wm4 wrote: > The old "API" that signaled rotation as a metadata value has been > replaced by DISPLAYMATRIX side data quite a while ago. > > There is no reason to make muxers/demuxers/API users support both. In > addition, the metadata API is dangerous, as

[FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-24 Thread wm4
The old "API" that signaled rotation as a metadata value has been replaced by DISPLAYMATRIX side data quite a while ago. There is no reason to make muxers/demuxers/API users support both. In addition, the metadata API is dangerous, as user tags could "leak" into it, creating unintended features or

Re: [FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-23 Thread Michael Niedermayer
On Thu, Mar 23, 2017 at 07:26:23AM +0100, wm4 wrote: > On Wed, 22 Mar 2017 19:32:11 +0100 > Michael Niedermayer wrote: > > > On Tue, Mar 21, 2017 at 08:42:58AM +0100, wm4 wrote: > > > The old "API" that signaled rotation as a metadata value has been > > > replaced by DISPLAYMATRIX side data quite

Re: [FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-22 Thread wm4
On Wed, 22 Mar 2017 19:32:11 +0100 Michael Niedermayer wrote: > On Tue, Mar 21, 2017 at 08:42:58AM +0100, wm4 wrote: > > The old "API" that signaled rotation as a metadata value has been > > replaced by DISPLAYMATRIX side data quite a while ago. > > > > There is no reason to make muxers/demuxers

Re: [FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-22 Thread Michael Niedermayer
On Tue, Mar 21, 2017 at 08:42:58AM +0100, wm4 wrote: > The old "API" that signaled rotation as a metadata value has been > replaced by DISPLAYMATRIX side data quite a while ago. > > There is no reason to make muxers/demuxers/API users support both. In > addition, the metadata API is dangerous, as

Re: [FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-21 Thread wm4
On Tue, 21 Mar 2017 14:09:49 +0100 Clément Bœsch wrote: > On Tue, Mar 21, 2017 at 08:42:58AM +0100, wm4 wrote: > > The old "API" that signaled rotation as a metadata value has been > > replaced by DISPLAYMATRIX side data quite a while ago. > > > > There is no reason to make muxers/demuxers/API u

Re: [FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-21 Thread Clément Bœsch
On Tue, Mar 21, 2017 at 08:42:58AM +0100, wm4 wrote: > The old "API" that signaled rotation as a metadata value has been > replaced by DISPLAYMATRIX side data quite a while ago. > > There is no reason to make muxers/demuxers/API users support both. In > addition, the metadata API is dangerous, as

Re: [FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-21 Thread Ronald S. Bultje
Hi, On Tue, Mar 21, 2017 at 3:45 AM, Carl Eugen Hoyos wrote: > 2017-03-21 8:42 GMT+01:00 wm4 : > > > There is no reason to make muxers/demuxers/API users support both. > > I don't understand this sentence: You mean having both APIs means > all users of FFmpeg have to support both APIs? Yes, of

Re: [FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-21 Thread Carl Eugen Hoyos
2017-03-21 8:42 GMT+01:00 wm4 : > There is no reason to make muxers/demuxers/API users support both. I don't understand this sentence: You mean having both APIs means all users of FFmpeg have to support both APIs? Carl Eugen ___ ffmpeg-devel mailing li

[FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

2017-03-21 Thread wm4
The old "API" that signaled rotation as a metadata value has been replaced by DISPLAYMATRIX side data quite a while ago. There is no reason to make muxers/demuxers/API users support both. In addition, the metadata API is dangerous, as user tags could "leak" into it, creating unintended features or